From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9466CA90AF for ; Wed, 13 May 2020 11:52:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A43AB206CC for ; Wed, 13 May 2020 11:52:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="vIcUolvz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731357AbgEMLwK (ORCPT ); Wed, 13 May 2020 07:52:10 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:60179 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725982AbgEMLwK (ORCPT ); Wed, 13 May 2020 07:52:10 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 6686F5C00ED; Wed, 13 May 2020 07:52:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 13 May 2020 07:52:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=0XLue2 QfJVQ/nueqNbe0kJXKe3qXzDhHzmczgkr+YNM=; b=vIcUolvzGcdag0UocMiV/l hWNm0Y6LDrlGPLOvDFuUKNwQEbzfxLNVDtMzzhToAgd4oO52d+f2/6eHbdHIr1Qd HmIYKM+Vh4e7dYqy7I+FHGk+ee2Tg1jULF+KHGlDtDhc4iqHWp9f7Tjbx10PMM7r nlEI3qa/FEvdbrVGkIvW1qcTs+iNe0iw9aQIaw5YvOio06L+r10E+/jL+5ajXqNm HxHz7rlpc6F+Z7i3vRno8J9DVQi9zDYSm/MIVZ2PJXszbHgKkcrNQh3/8LDduOPr ob2TxHe3F2sr6Wady1zapgMZKgCkyuNbWBhyAjVDIPPusFpjq/35LM8+XqrtR2Wg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrleeggdeghecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcuufgt hhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrthhtvg hrnheptdffkeekfeduffevgeeujeffjefhtefgueeugfevtdeiheduueeukefhudehleet necukfhppeejledrudejiedrvdegrddutdejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepihguohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: from localhost (bzq-79-176-24-107.red.bezeqint.net [79.176.24.107]) by mail.messagingengine.com (Postfix) with ESMTPA id A75D83066310; Wed, 13 May 2020 07:52:08 -0400 (EDT) Date: Wed, 13 May 2020 14:52:06 +0300 From: Ido Schimmel To: Christoph Hellwig Cc: davem@davemloft.net, netdev@vger.kernel.org Subject: Re: [PATCH] net: ignore sock_from_file errors in __scm_install_fd Message-ID: <20200513115206.GA601862@splinter> References: <20200513110759.2362955-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513110759.2362955-1-hch@lst.de> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, May 13, 2020 at 01:07:59PM +0200, Christoph Hellwig wrote: > The code had historically been ignoring these errors, and my recent > refactoring changed that, which broke ssh in some setups. > > Fixes: 2618d530dd8b ("net/scm: cleanup scm_detach_fds") > Reported-by: Ido Schimmel > Signed-off-by: Christoph Hellwig Tested-by: Ido Schimmel Thanks, Christoph.