From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B5DEC433E0 for ; Wed, 13 May 2020 17:14:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7859E205ED for ; Wed, 13 May 2020 17:14:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="w3mvih03" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389790AbgEMROl (ORCPT ); Wed, 13 May 2020 13:14:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732731AbgEMROk (ORCPT ); Wed, 13 May 2020 13:14:40 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 513FFC061A0C; Wed, 13 May 2020 10:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HStHYMCHMAld2jAQY6gz1O8fAw0LWyJlNm7iC5JM3JA=; b=w3mvih03C8N35b+4Bo9Ot7tr2 jgtW5Sh5X8sNAYy+j5tqw4QcbGeYxbFikVgq8C+oIlEF5CjnIMqJO1PWLeN7cBnMjSyiV3x+FcIAf US/X62EecXyz/0yIwlFJMTbYLsLBo89lYTmYwkBOQs9mSvd6WpfW9toFpDcXegZcAnjyT0TyrCNsz WuYZRUoazDCr7Of5oCHqIJ0mCfcP4jmBLBcT3DsE0L9yqVM4K+VY0vrT9Y022pjMxYVkkOzXcarUr Y7jc3k7yCWBKIsDshlPTRoynB/MT993/+xWLOX+Y8l2oDGgTLuRwTnoAHxtwI3n/d4/YDrnTgy49T nHSAJfAkw==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:39836) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYuxe-0005Lq-1O; Wed, 13 May 2020 18:14:29 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jYuxY-0007xA-TL; Wed, 13 May 2020 18:14:20 +0100 Date: Wed, 13 May 2020 18:14:20 +0100 From: Russell King - ARM Linux admin To: Andrew Lunn Cc: Doug Berger , "David S. Miller" , Florian Fainelli , Heiner Kallweit , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting Message-ID: <20200513171420.GL1551@shell.armlinux.org.uk> References: <1589243050-18217-1-git-send-email-opendmb@gmail.com> <1589243050-18217-2-git-send-email-opendmb@gmail.com> <20200512004714.GD409897@lunn.ch> <20200512185503.GD1551@shell.armlinux.org.uk> <0cf740ed-bd13-89d5-0f36-1e5305210e97@gmail.com> <20200513053405.GE1551@shell.armlinux.org.uk> <20200513092050.GB1605@shell.armlinux.org.uk> <20200513134925.GE499265@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513134925.GE499265@lunn.ch> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, May 13, 2020 at 03:49:25PM +0200, Andrew Lunn wrote: > Hi Russell, Doug > > With netlink ethtool we have the possibility of adding a new API to > control this. And we can leave the IOCTL API alone, and the current > ethtool commands. We can add a new command to ethtool which uses the new API. > > Question is, do we want to do this? Would we be introducing yet more > confusion, rather than making the situation better? The conclusion I came to was that I would document the deficiencies and do no more; I think people are used to its current quirky behaviour. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up