From: "John W. Linville" <linville@tuxdriver.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, mkubecek@suse.cz, davem@davemloft.net,
andrew@lunn.ch, vivien.didelot@gmail.com
Subject: Re: [PATCH] ethtool.c: Report transceiver correctly
Date: Wed, 13 May 2020 15:57:34 -0400 [thread overview]
Message-ID: <20200513195734.GF650568@tuxdriver.com> (raw)
In-Reply-To: <1585959695-26523-1-git-send-email-f.fainelli@gmail.com>
On Fri, Apr 03, 2020 at 05:21:35PM -0700, Florian Fainelli wrote:
> After the transition to the extended link settings ioctl API, the
> kernel, up until commit 9b3004953503462a4fab31b85e44ae446d48f0bd
> ("ethtool: drop get_settings and set_settings callbacks") would support
> the legacy link settings operation and report the transceiver type.
> After this commit, we lost that information although the Linux PHY
> library populates it correctly even with get_link_ksettings() method.
>
> Ensure that we report the transceiver type correctly for such cases.
>
> Fixes: 33133abf3b77 ("ethtool.c: add support for ETHTOOL_xLINKSETTINGS ioctls")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks (belatedly) -- queued for next release!
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2020-05-13 20:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-04 0:21 [PATCH] ethtool.c: Report transceiver correctly Florian Fainelli
2020-05-13 19:57 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513195734.GF650568@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).