From: "John W. Linville" <linville@tuxdriver.com>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev@vger.kernel.org, Konstantin Kharlamov <hi-angel@yandex.ru>
Subject: Re: [PATCH ethtool] features: accept long legacy flag names when setting features
Date: Wed, 13 May 2020 15:57:58 -0400 [thread overview]
Message-ID: <20200513195758.GG650568@tuxdriver.com> (raw)
In-Reply-To: <20200413212120.7D775E0FAD@unicorn.suse.cz>
On Mon, Apr 13, 2020 at 11:21:20PM +0200, Michal Kubecek wrote:
> The legacy feature flags have long names (e.g. "generic-receive-offload")
> and short names (e.g. "gro"). While "ethtool -k" shows only long names,
> "ethtool -K" accepts only short names. This is a bit confusing as users
> have to resort to documentation to see what flag name to use; in
> particular, if a legacy flag corresponds to only one actual kernel feature,
> "ethtool -k" shows the output in the same form as if long flag name were
> a kernel feature name but this name cannot be used to set the flag/feature.
>
> Accept both short and long legacy flag names in "ethool -K".
>
> Reported-by: Konstantin Kharlamov <hi-angel@yandex.ru>
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Thanks (belatedly) -- queued for next release!
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2020-05-13 20:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 21:21 [PATCH ethtool] features: accept long legacy flag names when setting features Michal Kubecek
2020-05-13 19:57 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513195758.GG650568@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=hi-angel@yandex.ru \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).