From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54AC7C433E0 for ; Wed, 13 May 2020 20:00:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4ADC205ED for ; Wed, 13 May 2020 20:00:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390697AbgEMUAO (ORCPT ); Wed, 13 May 2020 16:00:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1733135AbgEMUAO (ORCPT ); Wed, 13 May 2020 16:00:14 -0400 Received: from smtp.tuxdriver.com (tunnel92311-pt.tunnel.tserv13.ash1.ipv6.he.net [IPv6:2001:470:7:9c9::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BA873C061A0E for ; Wed, 13 May 2020 13:00:13 -0700 (PDT) Received: from uucp by smtp.tuxdriver.com with local-rmail (Exim 4.63) (envelope-from ) id 1jYxY3-00022U-2W; Wed, 13 May 2020 16:00:11 -0400 Received: from linville-x1.hq.tuxdriver.com (localhost.localdomain [127.0.0.1]) by linville-x1.hq.tuxdriver.com (8.15.2/8.14.6) with ESMTP id 04DJvwjI668286; Wed, 13 May 2020 15:57:59 -0400 Received: (from linville@localhost) by linville-x1.hq.tuxdriver.com (8.15.2/8.15.2/Submit) id 04DJvwCQ668285; Wed, 13 May 2020 15:57:58 -0400 Date: Wed, 13 May 2020 15:57:58 -0400 From: "John W. Linville" To: Michal Kubecek Cc: netdev@vger.kernel.org, Konstantin Kharlamov Subject: Re: [PATCH ethtool] features: accept long legacy flag names when setting features Message-ID: <20200513195758.GG650568@tuxdriver.com> References: <20200413212120.7D775E0FAD@unicorn.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200413212120.7D775E0FAD@unicorn.suse.cz> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Apr 13, 2020 at 11:21:20PM +0200, Michal Kubecek wrote: > The legacy feature flags have long names (e.g. "generic-receive-offload") > and short names (e.g. "gro"). While "ethtool -k" shows only long names, > "ethtool -K" accepts only short names. This is a bit confusing as users > have to resort to documentation to see what flag name to use; in > particular, if a legacy flag corresponds to only one actual kernel feature, > "ethtool -k" shows the output in the same form as if long flag name were > a kernel feature name but this name cannot be used to set the flag/feature. > > Accept both short and long legacy flag names in "ethool -K". > > Reported-by: Konstantin Kharlamov > Signed-off-by: Michal Kubecek Thanks (belatedly) -- queued for next release! John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.