From: David Miller <davem@davemloft.net>
To: irusskikh@marvell.com
Cc: netdev@vger.kernel.org, aelior@marvell.com,
mkalderon@marvell.com, dbolotin@marvell.com, kuba@kernel.org
Subject: Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling
Date: Thu, 14 May 2020 13:01:59 -0700 (PDT) [thread overview]
Message-ID: <20200514.130159.1188703412067742485.davem@davemloft.net> (raw)
In-Reply-To: <20200514095727.1361-1-irusskikh@marvell.com>
From: Igor Russkikh <irusskikh@marvell.com>
Date: Thu, 14 May 2020 12:57:16 +0300
> FastLinQ devices as a complex systems may observe various hardware
> level error conditions, both severe and recoverable.
>
> Driver is able to detect and report this, but so far it only did
> trace/dmesg based reporting.
>
> Here we implement an extended hw error detection, service task
> handler captures a dump for the later analysis.
>
> I also resubmit a patch from Denis Bolotin on tx timeout handler,
> addressing David's comment regarding recovery procedure as an extra
> reaction on this event.
>
> v2:
>
> Removing the patch with ethtool dump and udev magic. Its quite isolated,
> I'm working on devlink based logic for this separately.
>
> v1:
>
> https://patchwork.ozlabs.org/project/netdev/cover/cover.1588758463.git.irusskikh@marvell.com/
I'm only applying this series because I trust that you will actually do the
devlink work, and you will have it done and submitted in a reasonable amount
of ti me.
Also, patch #4 had trailing empty lines added to a file, which is
warned about by 'git' when I apply your patches. I fixed it up, but
this is the kind of thing you should have sorted out before you submit
changes to the list.
Thank you.
next prev parent reply other threads:[~2020-05-14 20:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 9:57 [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling Igor Russkikh
2020-05-14 9:57 ` [PATCH v2 net-next 01/11] net: qed: adding hw_err states and handling Igor Russkikh
2020-05-14 9:57 ` [PATCH v2 net-next 02/11] net: qede: add hw err scheduled handler Igor Russkikh
2020-05-14 9:57 ` [PATCH v2 net-next 03/11] net: qed: invoke err notify on critical areas Igor Russkikh
2020-05-14 9:57 ` [PATCH v2 net-next 04/11] net: qed: critical err reporting to management firmware Igor Russkikh
2020-05-14 9:57 ` [PATCH v2 net-next 05/11] net: qed: cleanup debug related declarations Igor Russkikh
2020-05-14 9:57 ` [PATCH v2 net-next 06/11] net: qed: attention clearing properties Igor Russkikh
2020-05-14 9:57 ` [PATCH v2 net-next 07/11] net: qede: optional hw recovery procedure Igor Russkikh
2020-05-14 9:57 ` [PATCH v2 net-next 08/11] net: qede: Implement ndo_tx_timeout Igor Russkikh
2020-05-14 9:57 ` [PATCH v2 net-next 09/11] net: qed: introduce critical fan failure handler Igor Russkikh
2020-05-14 9:57 ` [PATCH v2 net-next 10/11] net: qed: introduce critical hardware error handler Igor Russkikh
2020-05-14 9:57 ` [PATCH v2 net-next 11/11] net: qed: fix bad formatting Igor Russkikh
2020-05-14 19:06 ` [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling Jakub Kicinski
2020-05-14 19:40 ` [EXT] " Igor Russkikh
2020-05-14 20:02 ` Jakub Kicinski
2020-05-14 20:09 ` Igor Russkikh
2020-05-14 20:01 ` David Miller [this message]
2020-05-14 20:09 ` David Miller
2020-05-14 20:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514.130159.1188703412067742485.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aelior@marvell.com \
--cc=dbolotin@marvell.com \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=mkalderon@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).