From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: madhuparnabhowmik10@gmail.com, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, sfr@canb.auug.org.au,
frextrite@gmail.com, joel@joelfernandes.org, paulmck@kernel.org,
cai@lca.pw
Subject: Re: [PATCH] Fix suspicious RCU usage warning
Date: Thu, 14 May 2020 12:34:09 +0530 [thread overview]
Message-ID: <20200514070409.GA3174@madhuparna-HP-Notebook> (raw)
In-Reply-To: <20200513.120010.124458176293400943.davem@davemloft.net>
On Wed, May 13, 2020 at 12:00:10PM -0700, David Miller wrote:
> From: madhuparnabhowmik10@gmail.com
> Date: Wed, 13 May 2020 11:46:10 +0530
>
> > From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> >
> > This patch fixes the following warning:
> >
> > =============================
> > WARNING: suspicious RCU usage
> > 5.7.0-rc4-next-20200507-syzkaller #0 Not tainted
> > -----------------------------
> > net/ipv6/ip6mr.c:124 RCU-list traversed in non-reader section!!
> >
> > ipmr_new_table() returns an existing table, but there is no table at
> > init. Therefore the condition: either holding rtnl or the list is empty
> > is used.
> >
> > Suggested-by: Jakub Kicinski <kuba@kernel.org>
> > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> >
> > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> Please only provide one signoff line.
>
> Please provide a proper Fixes: tag for this bug fix.
>
> And finally, please make your Subject line more appropriate. It must
> first state the target tree inside of the "[PATCH]" area, the two choices
> are "[PATCH net]" and "[PATCH net-next]" and it depends upon which tree
> this patch is targetting.
>
> Then your Subject line should also be more descriptive about exactly the
> subsystem and area the change is being made to, for this change for
> example you could use something like:
>
> ipv6: Fix suspicious RCU usage warning in ip6mr.
>
> Also, obviously, there are also syzkaller tags you can add to the
> commit message as well.
Sorry for this malformed patch, I have sent a patch with all these
corrections.
Thank you,
Madhuparna
next prev parent reply other threads:[~2020-05-14 7:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 6:16 [PATCH] Fix suspicious RCU usage warning madhuparnabhowmik10
2020-05-13 11:52 ` Stephen Rothwell
2020-05-13 19:00 ` David Miller
2020-05-14 7:04 ` Madhuparna Bhowmik [this message]
2020-05-14 19:50 ` David Miller
2020-05-16 7:47 ` Madhuparna Bhowmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514070409.GA3174@madhuparna-HP-Notebook \
--to=madhuparnabhowmik10@gmail.com \
--cc=cai@lca.pw \
--cc=davem@davemloft.net \
--cc=frextrite@gmail.com \
--cc=joel@joelfernandes.org \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox