From: Richard Cochran <richardcochran@gmail.com>
To: Olivier Dautricourt <olivier.dautricourt@orolia.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] net: uapi: Add HWTSTAMP_FLAGS_ADJ_FINE/ADJ_COARSE
Date: Thu, 14 May 2020 06:38:09 -0700 [thread overview]
Message-ID: <20200514133809.GA18838@localhost> (raw)
In-Reply-To: <20200514102808.31163-3-olivier.dautricourt@orolia.com>
On Thu, May 14, 2020 at 12:28:07PM +0200, Olivier Dautricourt wrote:
> This commit allows a user to specify a flag value for configuring
> timestamping through hwtsamp_config structure.
>
> New flags introduced:
>
> HWTSTAMP_FLAGS_NONE = 0
> No flag specified: as it is of value 0, this will selects the
> default behavior for all the existing drivers and should not
> break existing userland programs.
>
> HWTSTAMP_FLAGS_ADJ_FINE = 1
> Use the fine adjustment mode.
> Fine adjustment mode is usually used for precise frequency adjustments.
>
> HWTSTAMP_FLAGS_ADJ_COARSE = 2
> Use the coarse adjustment mode
> Coarse adjustment mode is usually used for direct phase correction.
I'll have to NAK this change. The purpose of HWTSTAMP ioctl is to
configure the hardware time stamp settings. This patch would misuse
it for some other purpose.
Sorry,
Richard
next prev parent reply other threads:[~2020-05-14 13:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 10:28 [PATCH 0/3] Patch series for a PTP Grandmaster use case using stmmac/gmac3 ptp clock Olivier Dautricourt
2020-05-14 10:28 ` [PATCH 1/3] net: stmmac: gmac3: add auxiliary snapshot support Olivier Dautricourt
2020-05-14 10:28 ` [PATCH 2/3] net: uapi: Add HWTSTAMP_FLAGS_ADJ_FINE/ADJ_COARSE Olivier Dautricourt
2020-05-14 13:38 ` Richard Cochran [this message]
2020-05-14 15:20 ` Olivier Dautricourt
2020-05-15 0:29 ` Richard Cochran
2020-05-14 10:28 ` [PATCH 3/3] net: stmmac: Support coarse mode through ioctl Olivier Dautricourt
2020-05-27 3:55 ` Richard Cochran
2020-06-03 16:12 ` Olivier Dautricourt
2020-05-14 13:53 ` [PATCH 0/3] Patch series for a PTP Grandmaster use case using stmmac/gmac3 ptp clock Richard Cochran
2020-05-14 15:09 ` Olivier Dautricourt
2020-05-15 0:37 ` Richard Cochran
2020-05-15 13:26 ` Julien Beraud
2020-05-15 23:30 ` Richard Cochran
2020-05-25 10:00 ` Olivier Dautricourt
2020-05-27 4:05 ` Richard Cochran
2020-06-03 15:17 ` Olivier Dautricourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514133809.GA18838@localhost \
--to=richardcochran@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=netdev@vger.kernel.org \
--cc=olivier.dautricourt@orolia.com \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).