From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0F70C433E1 for ; Thu, 14 May 2020 16:02:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A111F2065F for ; Thu, 14 May 2020 16:02:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="GbjxuaBU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727790AbgENQB6 (ORCPT ); Thu, 14 May 2020 12:01:58 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60542 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726117AbgENQB6 (ORCPT ); Thu, 14 May 2020 12:01:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=msv2kokdkm+/p+wCqKHbElETQKCgYZ1C+ffdv0310YU=; b=GbjxuaBUHyknB++0VHT8Lm+Bng Wy7fICEnkQO49+5ENK6KkZ347Y0H7pNbib+2WiCqB4XgL2N954PF6zn/hzeQv136CqPnNLpV/pEhZ YmKQzpEnDxVgeNONAqQspYUNtsklsNlN6D2e4pStD/wgJhLF0zf2FT9V2EvCxQRXyDKs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jZGIy-002Iji-K1; Thu, 14 May 2020 18:01:52 +0200 Date: Thu, 14 May 2020 18:01:52 +0200 From: Andrew Lunn To: Christian Herber Cc: Oleksij Rempel , Mark Rutland , Marek Vasut , Florian Fainelli , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Pengutronix Kernel Team , David Jander , "David S. Miller" , Heiner Kallweit Subject: Re: [EXT] Re: [PATCH net-next v1] net: phy: tja11xx: add cable-test support Message-ID: <20200514160152.GU499265@lunn.ch> References: <20200513123440.19580-1-o.rempel@pengutronix.de> <20200513133925.GD499265@lunn.ch> <20200513174011.kl6l767cimeo6dpy@pengutronix.de> <20200513180140.GK499265@lunn.ch> <20200514120959.b24cszsmkjvfzss6@pengutronix.de> <20200514133823.GO527401@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, May 14, 2020 at 03:47:16PM +0000, Christian Herber wrote: > Hi Andrew, > > > On Wed, May 13, 2020 at 03:39:00PM +0200, Andrew Lunn wrote: > >> On Thu, May 14, 2020 at 02:09:59PM +0200, Oleksij Rempel wrote: > >> ETHTOOL_A_CABLE_RESULT_CODE_ACTIVE_PARTNER - the link partner is active. > >> > >> The TJA1102 is able to detect it if partner link is master. > >> > > master is not a cable diagnostics issue. This is a configuration > > issue. > > Master is very relevant for cable diagnostics, as a cable > measurement should not be done with an active link partner on the > other end (i.e. a PHY in master mode trying to train the link). > So if the measurement detects an active link partner disturbing the > measurement, it is important to report this to the user. So with 'normal' PHYs, we use autoneg to make the link go quiet. But you don't have autoneg. If there is no way to force the link quiet, then ETHTOOL_A_CABLE_RESULT_CODE_ACTIVE_PARTNER makes sense. But we need to keep the meaning generic. I don't want it to mean a T1 PHY with an active master peer. It should be usable for any reason the link cannot be made to go quiet. Andrew