From: Andrew Lunn <andrew@lunn.ch>
To: Dan Murphy <dmurphy@ti.com>
Cc: f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net,
robh@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: phy: DP83822: Add ability to advertise Fiber connection
Date: Thu, 14 May 2020 20:52:17 +0200 [thread overview]
Message-ID: <20200514185217.GX499265@lunn.ch> (raw)
In-Reply-To: <20200514173055.15013-3-dmurphy@ti.com>
> +static int dp83822_config_init(struct phy_device *phydev)
> +{
> + struct dp83822_private *dp83822 = phydev->priv;
> + int err = 0;
> +
> + if (dp83822->fx_enabled) {
> + linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BIT,
> + phydev->supported);
> + linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BIT,
> + phydev->advertising);
> +
> + /* Auto negotiation is not available in fiber mode */
> + phydev->autoneg = AUTONEG_DISABLE;
> + phydev->speed = SPEED_100;
> + phydev->duplex = DUPLEX_FULL;
Hi Dan
This is normally determined by reading the ability registers,
genphy_read_abilities(). When strapped to fibre mode, does it still
indicate all the usual copper capabilities, which it can not actually
do?
Andrew
next prev parent reply other threads:[~2020-05-14 19:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 17:30 [PATCH net-next 0/2] DP83822 Fiber enablement Dan Murphy
2020-05-14 17:30 ` [PATCH net-next 1/2] dt-bindings: net: dp83822: Add TI dp83822 phy Dan Murphy
2020-05-14 18:39 ` Andrew Lunn
2020-05-14 19:38 ` Dan Murphy
2020-05-14 20:50 ` Andrew Lunn
2020-05-14 20:51 ` Dan Murphy
2020-05-14 21:04 ` Andrew Lunn
2020-05-28 17:48 ` Rob Herring
2020-05-14 17:30 ` [PATCH net-next 2/2] net: phy: DP83822: Add ability to advertise Fiber connection Dan Murphy
2020-05-14 18:52 ` Andrew Lunn [this message]
2020-05-14 21:43 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514185217.GX499265@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).