From: Kevin Lo <kevlo@kevlo.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net] net: phy: broadcom: add support for BCM54811 PHY
Date: Sat, 16 May 2020 01:22:58 +0800 [thread overview]
Message-ID: <20200515172258.GA2035@ns.kevlo.org> (raw)
In-Reply-To: <b2f12255-83a6-9de2-c82f-ebdc6b0352f2@gmail.com>
On Fri, May 15, 2020 at 08:53:37AM -0700, Florian Fainelli wrote:
>
>
>
> On 5/14/2020 10:22 PM, Kevin Lo wrote:
> > The BCM54811 PHY shares many similarities with the already supported BCM54810
> > PHY but additionally requires some semi-unique configuration.
>
> This looks mostly fine, just a couple of nits:
>
> - the patch should be submitted against net-next, since it is a new
> feature/addition and not a bug fix
>
> - you need an additional entry to support the automatic loading of the
> PHY driver, that means adding an entry to the broadcom_tbl array.
Thanks for the review. I'm going to send it to net-next.
>
> With that:
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> --
> Florian
prev parent reply other threads:[~2020-05-15 20:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 5:22 [PATCH net] net: phy: broadcom: add support for BCM54811 PHY Kevin Lo
2020-05-15 15:53 ` Florian Fainelli
2020-05-15 17:22 ` Kevin Lo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515172258.GA2035@ns.kevlo.org \
--to=kevlo@kevlo.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).