From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91BC4C433E0 for ; Sat, 16 May 2020 02:12:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6925C20756 for ; Sat, 16 May 2020 02:12:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727779AbgEPCM3 (ORCPT ); Fri, 15 May 2020 22:12:29 -0400 Received: from ns.kevlo.org ([220.134.220.36]:55785 "EHLO ns.kevlo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726290AbgEPCM3 (ORCPT ); Fri, 15 May 2020 22:12:29 -0400 Received: from ns.kevlo.org (localhost [127.0.0.1]) by ns.kevlo.org (8.15.2/8.15.2) with ESMTPS id 04G2Bxbg006096 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 16 May 2020 10:12:01 +0800 (CST) (envelope-from kevlo@ns.kevlo.org) Received: (from kevlo@localhost) by ns.kevlo.org (8.15.2/8.15.2/Submit) id 04G2BvAI006095; Sat, 16 May 2020 10:11:57 +0800 (CST) (envelope-from kevlo) Date: Sat, 16 May 2020 10:11:57 +0800 From: Kevin Lo To: Jakub Kicinski Cc: netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , "David S. Miller" Subject: Re: [PATCH net-next] net: phy: broadcom: add support for BCM54811 PHY Message-ID: <20200516021157.GA6075@ns.kevlo.org> References: <20200515172447.GA2101@ns.kevlo.org> <20200515143142.20ee5a5d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200515143142.20ee5a5d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, May 15, 2020 at 02:31:42PM -0700, Jakub Kicinski wrote: > > On Sat, 16 May 2020 01:24:47 +0800 Kevin Lo wrote: > > The BCM54811 PHY shares many similarities with the already supported BCM54810 > > PHY but additionally requires some semi-unique configuration. > > > > Signed-off-by: Kevin Lo > > Reviewed-by: Florian Fainelli > > Checkpatch complains about using spaces instead of tabs: > > ERROR: code indent should use tabs where possible > #80: FILE: drivers/net/phy/broadcom.c:359: > + }$ Thanks for spotting this out. Will send the patch to fix it.