From: Michal Kubecek <mkubecek@suse.cz>
To: David Miller <davem@davemloft.net>
Cc: kuba@kernel.org, netdev@vger.kernel.org,
simon.horman@netronome.com, kernel-team@fb.com
Subject: Re: [PATCH net-next 0/3] ethtool: set_channels: add a few more checks
Date: Sat, 16 May 2020 23:13:03 +0200 [thread overview]
Message-ID: <20200516211302.GA15101@lion.mk-sys.cz> (raw)
In-Reply-To: <20200516.135658.485531358159506210.davem@davemloft.net>
On Sat, May 16, 2020 at 01:56:58PM -0700, David Miller wrote:
> From: Jakub Kicinski <kuba@kernel.org>
> Date: Fri, 15 May 2020 12:48:59 -0700
>
> > There seems to be a few more things we can check in the core before
> > we call drivers' ethtool_ops->set_channels. Adding the checks to
> > the core simplifies the drivers. This set only includes changes
> > to the NFP driver as an example.
> >
> > There is a small risk in the first patch that someone actually
> > purposefully accepts a strange configuration without RX or TX
> > channels, but I couldn't find such a driver in the tree.
>
> Series applied, thanks Jakub.
>
> And for the record I accept logical 'or' of booleans as valid :-)
For the record, my point was that "|=" is a bitwise operator, not logical.
Michal
prev parent reply other threads:[~2020-05-16 21:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 19:48 [PATCH net-next 0/3] ethtool: set_channels: add a few more checks Jakub Kicinski
2020-05-15 19:49 ` [PATCH net-next 1/3] ethtool: check if there is at least one channel for TX/RX in the core Jakub Kicinski
2020-05-15 20:56 ` Michal Kubecek
2020-05-15 22:26 ` Jakub Kicinski
2020-05-15 19:49 ` [PATCH net-next 2/3] nfp: don't check lack of RX/TX channels Jakub Kicinski
2020-05-15 20:59 ` Michal Kubecek
2020-05-18 11:44 ` Simon Horman
2020-05-15 19:49 ` [PATCH net-next 3/3] ethtool: don't call set_channels in drivers if config didn't change Jakub Kicinski
2020-05-15 21:01 ` Michal Kubecek
2020-05-16 20:56 ` [PATCH net-next 0/3] ethtool: set_channels: add a few more checks David Miller
2020-05-16 21:13 ` Michal Kubecek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200516211302.GA15101@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).