From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D5DFC433DF for ; Sat, 16 May 2020 21:13:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44D2D206D8 for ; Sat, 16 May 2020 21:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726680AbgEPVNF (ORCPT ); Sat, 16 May 2020 17:13:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:48376 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726663AbgEPVNF (ORCPT ); Sat, 16 May 2020 17:13:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 9A107AC7B; Sat, 16 May 2020 21:13:06 +0000 (UTC) Received: by lion.mk-sys.cz (Postfix, from userid 1000) id 11CA060347; Sat, 16 May 2020 23:13:03 +0200 (CEST) Date: Sat, 16 May 2020 23:13:03 +0200 From: Michal Kubecek To: David Miller Cc: kuba@kernel.org, netdev@vger.kernel.org, simon.horman@netronome.com, kernel-team@fb.com Subject: Re: [PATCH net-next 0/3] ethtool: set_channels: add a few more checks Message-ID: <20200516211302.GA15101@lion.mk-sys.cz> References: <20200515194902.3103469-1-kuba@kernel.org> <20200516.135658.485531358159506210.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200516.135658.485531358159506210.davem@davemloft.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, May 16, 2020 at 01:56:58PM -0700, David Miller wrote: > From: Jakub Kicinski > Date: Fri, 15 May 2020 12:48:59 -0700 > > > There seems to be a few more things we can check in the core before > > we call drivers' ethtool_ops->set_channels. Adding the checks to > > the core simplifies the drivers. This set only includes changes > > to the NFP driver as an example. > > > > There is a small risk in the first patch that someone actually > > purposefully accepts a strange configuration without RX or TX > > channels, but I couldn't find such a driver in the tree. > > Series applied, thanks Jakub. > > And for the record I accept logical 'or' of booleans as valid :-) For the record, my point was that "|=" is a bitwise operator, not logical. Michal