Re: [PATCH 05/17] mmc: renesas_sdhi_sys_dmac: Add support for r8a7742 SoC

Geert Uytterhoeven
2020-05-18T11:24:32Z

Hi Wolfram, Prabhakar,

On Fri, May 15, 2020 at 7:17 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> On Fri, May 15, 2020 at 04:08:45PM +0100, Lad Prabhakar wrote:
> > Add support for r8a7742 SoC. Renesas RZ/G1H (R8A7742) SDHI is identical to
> > the R-Car Gen2 family.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
>
> I think we can skip this because of the generic fallback? The other

Agreed.

> entries come from a time when we had a different policy IIRC.

Indeed. Commit c16a854e4463078a ("mmc: renesas_sdhi: Add r8a7743/5
support") predated commit d6dc425ae595e140 ("mmc: renesas_sdhi:
implement R-Car Gen[123] fallback compatibility strings").

> > --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> > +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> > @@ -75,6 +75,7 @@ static const struct of_device_id renesas_sdhi_sys_dmac_of_match[] = {
> > { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, },
> > { .compatible = "renesas,sdhi-r8a7778", .data = &of_rcar_gen1_compatible, },
> > { .compatible = "renesas,sdhi-r8a7779", .data = &of_rcar_gen1_compatible, },
> > + { .compatible = "renesas,sdhi-r8a7742", .data = &of_rcar_gen2_compatible, },
> > { .compatible = "renesas,sdhi-r8a7743", .data = &of_rcar_gen2_compatible, },
> > { .compatible = "renesas,sdhi-r8a7745", .data = &of_rcar_gen2_compatible, },
> > { .compatible = "renesas,sdhi-r8a7790", .data = &of_rcar_gen2_compatible, },

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds