Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node

Lad, Prabhakar
2020-05-18T13:23:45Z

Hi Sergei,

On Mon, May 18, 2020 at 2:17 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
>
> Hello!
>
> On 18.05.2020 15:27, Lad, Prabhakar wrote:
>
> >>> Add a device node for the Watchdog Timer (RWDT) controller on the Renesas
> >>> RZ/G1H (r8a7742) SoC.
> >>>
> >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >>> Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> >>
> >> Thanks for your patch!
> >>
> >>> --- a/arch/arm/boot/dts/r8a7742.dtsi
> >>> +++ b/arch/arm/boot/dts/r8a7742.dtsi
> >>> @@ -201,6 +201,16 @@
> >>> #size-cells = <2>;
> >>> ranges;
> >>>
> >>> + rwdt: watchdog@e6020000 {
> >>> + compatible = "renesas,r8a7742-wdt",
> >>> + "renesas,rcar-gen2-wdt";
> >>> + reg = <0 0xe6020000 0 0x0c>;
> >>> + clocks = <&cpg CPG_MOD 402>;
> >>> + power-domains = <&sysc R8A7742_PD_ALWAYS_ON>;
> >>> + resets = <&cpg 402>;
> >>> + status = "disabled";
> >>
> >> Missing "interrupts" property.
> >>
> > "interrupts" property isn't used by rwdt driver and can be dropped
> > from bindings file.
>
> DT describes the hardware, not its driver's abilities.
>
Agreed will add, I had followed it on similar lines of r8a7743/44.

Cheers,
--Prabhakar