From: Jiri Pirko <jiri@resnulli.us>
To: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/4] bnxt_en: Add new "enable_hot_fw_reset" generic devlink parameter
Date: Mon, 18 May 2020 13:01:52 +0200 [thread overview]
Message-ID: <20200518110152.GB2193@nanopsycho> (raw)
In-Reply-To: <1589790439-10487-1-git-send-email-vasundhara-v.volam@broadcom.com>
Mon, May 18, 2020 at 10:27:15AM CEST, vasundhara-v.volam@broadcom.com wrote:
>This patchset adds support for a "enable_hot_fw_reset" generic devlink
>parameter and use it in bnxt_en driver.
>
>Also, firmware spec. is updated to 1.10.1.40.
Hi.
We've been discussing this internally for some time.
I don't like to use params for this purpose.
We already have "devlink dev flash" and "devlink dev reload" commands.
Combination of these two with appropriate attributes should provide what
you want. The "param" you are introducing is related to either "flash"
or "reload", so I don't think it is good to have separate param, when we
can extend the command attributes.
How does flash&reload work for mlxsw now:
# devlink flash
Now new version is pending, old FW is running
# devlink reload
Driver resets the device, new FW is loaded
I propose to extend reload like this:
devlink dev reload DEV [ level { driver-default | fw-reset | driver-only | fw-live-patch } ]
driver-default - means one of following to, according to what is
default for the driver
fw-reset - does FW reset and driver entities re-instantiation
driver-only - does driver entities re-instantiation only
fw-live-patch - does only FW live patching - no effect on kernel
Could be an enum or bitfield. Does not matter. The point is to use
reload with attribute to achieve what user wants. In your usecase, user
would do:
# devlink flash
# devlink reload level fw-live-patch
next prev parent reply other threads:[~2020-05-18 11:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 8:27 [PATCH net-next 0/4] bnxt_en: Add new "enable_hot_fw_reset" generic devlink parameter Vasundhara Volam
2020-05-18 8:27 ` [PATCH net-next 1/4] devlink: Add new "enable_hot_fw_reset" generic device parameter Vasundhara Volam
2020-05-18 8:27 ` [PATCH net-next 2/4] bnxt_en: Update firmware spec. to 1.10.1.40 Vasundhara Volam
2020-05-18 8:27 ` [PATCH net-next 3/4] bnxt_en: Use enable_hot_fw_reset generic devlink parameter Vasundhara Volam
2020-05-18 8:27 ` [PATCH net-next 4/4] bnxt_en: Check if hot_fw_reset is allowed before doing ETHTOOL_RESET Vasundhara Volam
2020-05-18 11:01 ` Jiri Pirko [this message]
2020-05-18 23:43 ` [PATCH net-next 0/4] bnxt_en: Add new "enable_hot_fw_reset" generic devlink parameter Jakub Kicinski
2020-05-19 5:24 ` Jiri Pirko
2020-05-19 17:44 ` Jakub Kicinski
2020-05-19 4:31 ` Vasundhara Volam
2020-05-19 5:27 ` Jiri Pirko
2020-05-19 5:43 ` Vasundhara Volam
2020-05-19 7:30 ` Jiri Pirko
2020-05-19 8:41 ` Michael Chan
2020-05-19 9:41 ` Jiri Pirko
2020-05-19 10:50 ` Vasundhara Volam
2020-05-19 13:25 ` Jiri Pirko
2020-05-19 7:13 ` Edwin Peer
2020-05-19 7:29 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518110152.GB2193@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vasundhara-v.volam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).