From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D35A8C433E0 for ; Tue, 19 May 2020 22:23:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE345206C3 for ; Tue, 19 May 2020 22:23:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728021AbgESWXm (ORCPT ); Tue, 19 May 2020 18:23:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726898AbgESWXl (ORCPT ); Tue, 19 May 2020 18:23:41 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2A84C061A0F for ; Tue, 19 May 2020 15:23:41 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1A7E5128EC8C8; Tue, 19 May 2020 15:23:39 -0700 (PDT) Date: Tue, 19 May 2020 15:23:35 -0700 (PDT) Message-Id: <20200519.152335.968463052378721004.davem@davemloft.net> To: ybason@marvell.com Cc: mkalderon@marvell.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next,v2 2/2] qed: Add XRC to RoCE From: David Miller In-Reply-To: <20200519205126.26987-3-ybason@marvell.com> References: <20200519205126.26987-1-ybason@marvell.com> <20200519205126.26987-3-ybason@marvell.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 19 May 2020 15:23:39 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yuval Basson Date: Tue, 19 May 2020 23:51:26 +0300 > @@ -1748,24 +1839,26 @@ static int qed_rdma_modify_srq(void *rdma_cxt, > u16 opaque_fid, srq_id; > struct qed_bmap *bmap; > u32 returned_id; > + u16 offset; > int rc; > > - bmap = &p_hwfn->p_rdma_info->srq_map; > + bmap = qed_rdma_get_srq_bmap(p_hwfn, in_params->is_xrc); > spin_lock_bh(&p_hwfn->p_rdma_info->lock); > rc = qed_rdma_bmap_alloc_id(p_hwfn, bmap, &returned_id); > spin_unlock_bh(&p_hwfn->p_rdma_info->lock); > > if (rc) { > - DP_NOTICE(p_hwfn, "failed to allocate srq id\n"); > + DP_NOTICE(p_hwfn, > + "failed to allocate xrc/srq id (is_xrc=%u)\n", > + in_params->is_xrc); > return rc; > } > > - elem_type = QED_ELEM_SRQ; > + elem_type = (in_params->is_xrc) ? (QED_ELEM_XRC_SRQ) : (QED_ELEM_SRQ); > rc = qed_cxt_dynamic_ilt_alloc(p_hwfn, elem_type, returned_id); > if (rc) > goto err; This "if (rc)" error path will leak 'returned_id' won't it?