From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB925C433E0 for ; Tue, 19 May 2020 07:30:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8842F2075F for ; Tue, 19 May 2020 07:30:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="l+vwzsmv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728463AbgESHaf (ORCPT ); Tue, 19 May 2020 03:30:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726892AbgESHaf (ORCPT ); Tue, 19 May 2020 03:30:35 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 175FBC061A0C for ; Tue, 19 May 2020 00:30:35 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id f134so1941394wmf.1 for ; Tue, 19 May 2020 00:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=75kjOhwcBeyDdAl6p+9aXDIULdp0927c7hM4LOyhKak=; b=l+vwzsmvGLirND5yyVVuIgzIh5pOuAs8WJEiliaTomEy95tzfgDNBws5qqt7fcZH2A KHY/DSdNoMTY6comvV0RilTEvTENSr3Rf/7xYX/e+FRf8B7kBCtQXnyVIzMc0NKJdchQ AM0x2tv+nSR2bnKOf6TlKOsqHhUnMLgL5WX2XFfvBgOJ6EVhyijVpqreg2ASTfR3Yoh8 zWzOwmFZSCgkIMmgASS+3ycwG1X9b5cgmu7uFwf/bWZd2ipt572FtnfeDfb4wq8eQh74 cZ/EZQBkKeUVoezAaHr8dT2wisdcOifwoxANu1SYkDvVw3E7CA/7ts/OeoeET6lAZQoO l7Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=75kjOhwcBeyDdAl6p+9aXDIULdp0927c7hM4LOyhKak=; b=KsYn0gsw+hqsppMzta6WzT04CTI0CS2UHRTU2kPwN6KNnysF7UfT1Py6CpGkyogtPE 6Rp24MKYYjbGX1ixJ3vqU4Uvv1TMXBqwapxXqo8ol4OWx2pRx+IYkzKhWQQbcboHuIEs cYrZ96FmrWEREnGVlzGWQoliss0iNtbjevwXkHtJYjT59T21dyZRMhG2GgLFTB7gNYT3 98jJCmoEElf5ptVZdV7WKSewt8ROwslfZXZqH9Jrx5KVxG5Ew7TIMulblEkHNcXqSou2 i5cMkCS1NW6RVnfiP5fJOtlmA6mbidiixMmYajLtVKKCDNlZnHDCM8zc4HGUU/FCdjHu zyDg== X-Gm-Message-State: AOAM5334Jqa1AMm40XRHncdCFoOk440Gg6EZI2GJUoBW1oOzBODWi3GL 6iinF87JHq3iBgdrlMGxgeJc3A== X-Google-Smtp-Source: ABdhPJy4QWjjY07i8DDZKs2V+QrgAG2YOrCehxak2+LY0+q6/h8Wk5fMaLLs4iAT+jbFHiRfGeqPsQ== X-Received: by 2002:a1c:a74a:: with SMTP id q71mr3713691wme.23.1589873433856; Tue, 19 May 2020 00:30:33 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id i4sm15237777wrv.23.2020.05.19.00.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 00:30:33 -0700 (PDT) Date: Tue, 19 May 2020 09:30:32 +0200 From: Jiri Pirko To: Vasundhara Volam Cc: David Miller , Netdev Subject: Re: [PATCH net-next 0/4] bnxt_en: Add new "enable_hot_fw_reset" generic devlink parameter Message-ID: <20200519073032.GE4655@nanopsycho> References: <1589790439-10487-1-git-send-email-vasundhara-v.volam@broadcom.com> <20200518110152.GB2193@nanopsycho> <20200519052745.GC4655@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, May 19, 2020 at 07:43:01AM CEST, vasundhara-v.volam@broadcom.com wrote: >On Tue, May 19, 2020 at 10:57 AM Jiri Pirko wrote: >> >> Tue, May 19, 2020 at 06:31:27AM CEST, vasundhara-v.volam@broadcom.com wrote: >> >On Mon, May 18, 2020 at 4:31 PM Jiri Pirko wrote: >> >> >> >> Mon, May 18, 2020 at 10:27:15AM CEST, vasundhara-v.volam@broadcom.com wrote: >> >> >This patchset adds support for a "enable_hot_fw_reset" generic devlink >> >> >parameter and use it in bnxt_en driver. >> >> > >> >> >Also, firmware spec. is updated to 1.10.1.40. >> >> >> >> Hi. >> >> >> >> We've been discussing this internally for some time. >> >> I don't like to use params for this purpose. >> >> We already have "devlink dev flash" and "devlink dev reload" commands. >> >> Combination of these two with appropriate attributes should provide what >> >> you want. The "param" you are introducing is related to either "flash" >> >> or "reload", so I don't think it is good to have separate param, when we >> >> can extend the command attributes. >> >> >> >> How does flash&reload work for mlxsw now: >> >> >> >> # devlink flash >> >> Now new version is pending, old FW is running >> >> # devlink reload >> >> Driver resets the device, new FW is loaded >> >> >> >> I propose to extend reload like this: >> >> >> >> devlink dev reload DEV [ level { driver-default | fw-reset | driver-only | fw-live-patch } ] >> >> driver-default - means one of following to, according to what is >> >> default for the driver >> >> fw-reset - does FW reset and driver entities re-instantiation >> >> driver-only - does driver entities re-instantiation only >> >> fw-live-patch - does only FW live patching - no effect on kernel >> >> >> >> Could be an enum or bitfield. Does not matter. The point is to use >> >> reload with attribute to achieve what user wants. In your usecase, user >> >> would do: >> >> >> >> # devlink flash >> >> # devlink reload level fw-live-patch >> > >> >Jiri, >> > >> >I am adding this param to control the fw hot reset capability of the device. >> >> I don't follow, sorry. Could you be more verbose about what you are >> trying to achieve here? >As mentioned below, hot_fw_reset is a device capability similar to roce. >Capability can be enabled or disabled on the device, if the device supports. >When enabled and if supported firmware and driver are loaded, user can >utilise the capability to fw_reset or fw_live_patch. I don't undestand what exactly is this supposed to enable/disable. Could you be more specific? > >So, we need a policy to enable/disable the capability. > >Thanks. >> >> >Permanent configuration mode will toggle the NVM config space which is >> >very similar to enable_roce/enable_sriov param and runtime configuration >> >mode will toggle the driver level knob to avoid/allow fw-live-reset. >> > >> >From above. I see that you are suggesting how to trigger the fw hot reset. >> >This is good to have, but does not serve the purpose of enabling or disabling >> >of the feature. Our driver is currently using "ethtool --reset" for >> >triggering fw-reset >> >or fw-live-patch. >> > >> >Thanks, >> >Vasundhara