From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Yonghong Song <yhs@fb.com>
Cc: Andrii Nakryiko <andriin@fb.com>, <bpf@vger.kernel.org>,
<netdev@vger.kernel.org>, <ast@fb.com>, <daniel@iogearbox.net>,
<andrii.nakryiko@gmail.com>, <kernel-team@fb.com>,
brouer@redhat.com
Subject: Re: [PATCH bpf-next] selftest/bpf: make bpf_iter selftest compilable against old vmlinux.h
Date: Tue, 19 May 2020 09:01:25 +0200 [thread overview]
Message-ID: <20200519090125.2612b00c@carbon> (raw)
In-Reply-To: <6633a04c-aab4-5182-2bed-28b235436932@fb.com>
On Mon, 18 May 2020 18:42:24 -0700
Yonghong Song <yhs@fb.com> wrote:
> On 5/18/20 4:45 PM, Andrii Nakryiko wrote:
> > It's good to be able to compile bpf_iter selftest even on systems that don't
> > have the very latest vmlinux.h, e.g., for libbpf tests against older kernels in
> > Travis CI. To that extent, re-define bpf_iter_meta and corresponding bpf_iter
> > context structs in each selftest. To avoid type clashes with vmlinux.h, rename
> > vmlinux.h's definitions to get them out of the way.
> >
> > Cc: Jesper Dangaard Brouer <brouer@redhat.com>
> > Cc: Yonghong Song <yhs@fb.com>
> > Signed-off-by: Andrii Nakryiko <andriin@fb.com>
>
> Acked-by: Yonghong Song <yhs@fb.com>
Thanks for looking into this Andrii :-)
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-05-19 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 23:45 [PATCH bpf-next] selftest/bpf: make bpf_iter selftest compilable against old vmlinux.h Andrii Nakryiko
2020-05-19 1:42 ` Yonghong Song
2020-05-19 7:01 ` Jesper Dangaard Brouer [this message]
2020-05-19 18:44 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519090125.2612b00c@carbon \
--to=brouer@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).