From: Jiri Pirko <jiri@resnulli.us>
To: Michael Chan <michael.chan@broadcom.com>
Cc: Vasundhara Volam <vasundhara-v.volam@broadcom.com>,
David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 0/4] bnxt_en: Add new "enable_hot_fw_reset" generic devlink parameter
Date: Tue, 19 May 2020 11:41:32 +0200 [thread overview]
Message-ID: <20200519094132.GG4655@nanopsycho> (raw)
In-Reply-To: <CACKFLinpyX-sgkOMQd=uEVZzn1-+doJoV-t5NRRNrcnE+=tR3A@mail.gmail.com>
Tue, May 19, 2020 at 10:41:44AM CEST, michael.chan@broadcom.com wrote:
>On Tue, May 19, 2020 at 12:30 AM Jiri Pirko <jiri@resnulli.us> wrote:
>>
>> Tue, May 19, 2020 at 07:43:01AM CEST, vasundhara-v.volam@broadcom.com wrote:
>> >On Tue, May 19, 2020 at 10:57 AM Jiri Pirko <jiri@resnulli.us> wrote:
>> >>
>> >> I don't follow, sorry. Could you be more verbose about what you are
>> >> trying to achieve here?
>> >As mentioned below, hot_fw_reset is a device capability similar to roce.
>> >Capability can be enabled or disabled on the device, if the device supports.
>> >When enabled and if supported firmware and driver are loaded, user can
>> >utilise the capability to fw_reset or fw_live_patch.
>>
>> I don't undestand what exactly is this supposed to enable/disable. Could
>> you be more specific?
>
>Let me see if I can help clarify. Here's a little background. Hot
>reset is a feature supported by the firmware and requires the
>coordinated support of all function drivers. The firmware will only
>initiate this hot reset when all function drivers can support it. For
>example, if one function is running a really old driver that doesn't
>support it, the firmware will not support this until this old driver
>gets unloaded or upgraded. Until then, a PCI reset is needed to reset
>the firmware.
>
>Now, let's say one function driver that normally supports this
>firmware hot reset now wants to disable this feature. For example,
>the function is running a mission critical application and does not
>want any hot firmware reset that may cause a hiccup during this time.
>It will use this devlink parameter to disable it. When the critical
>app is done, it can then re-enable the parameter. Of course other
>functions can also disable it and it is only enabled when all
>functions have enabled it.
>
>Hope this clarifies it. Thanks.
Okay. So this is about the "allowing to be reseted from the outside".
I see. For that I think it makes sense to have the devlink param.
However, I think that it would be fine to find more suitable name and
describe this properly in the docs.
next prev parent reply other threads:[~2020-05-19 9:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 8:27 [PATCH net-next 0/4] bnxt_en: Add new "enable_hot_fw_reset" generic devlink parameter Vasundhara Volam
2020-05-18 8:27 ` [PATCH net-next 1/4] devlink: Add new "enable_hot_fw_reset" generic device parameter Vasundhara Volam
2020-05-18 8:27 ` [PATCH net-next 2/4] bnxt_en: Update firmware spec. to 1.10.1.40 Vasundhara Volam
2020-05-18 8:27 ` [PATCH net-next 3/4] bnxt_en: Use enable_hot_fw_reset generic devlink parameter Vasundhara Volam
2020-05-18 8:27 ` [PATCH net-next 4/4] bnxt_en: Check if hot_fw_reset is allowed before doing ETHTOOL_RESET Vasundhara Volam
2020-05-18 11:01 ` [PATCH net-next 0/4] bnxt_en: Add new "enable_hot_fw_reset" generic devlink parameter Jiri Pirko
2020-05-18 23:43 ` Jakub Kicinski
2020-05-19 5:24 ` Jiri Pirko
2020-05-19 17:44 ` Jakub Kicinski
2020-05-19 4:31 ` Vasundhara Volam
2020-05-19 5:27 ` Jiri Pirko
2020-05-19 5:43 ` Vasundhara Volam
2020-05-19 7:30 ` Jiri Pirko
2020-05-19 8:41 ` Michael Chan
2020-05-19 9:41 ` Jiri Pirko [this message]
2020-05-19 10:50 ` Vasundhara Volam
2020-05-19 13:25 ` Jiri Pirko
2020-05-19 7:13 ` Edwin Peer
2020-05-19 7:29 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519094132.GG4655@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vasundhara-v.volam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).