From: Stephen Hemminger <stephen@networkplumber.org>
To: Roman Mashak <mrv@mojatatu.com>
Cc: dsahern@gmail.com, netdev@vger.kernel.org, kernel@mojatatu.com,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH iproute2-next 1/1] tc: report time an action was first used
Date: Tue, 19 May 2020 11:06:10 -0700 [thread overview]
Message-ID: <20200519110610.2c825a5c@hermes.lan> (raw)
In-Reply-To: <1589722125-21710-1-git-send-email-mrv@mojatatu.com>
On Sun, 17 May 2020 09:28:45 -0400
Roman Mashak <mrv@mojatatu.com> wrote:
> + if (tm->firstuse != 0) {
> + print_uint(PRINT_JSON, "first_used", NULL, tm->firstuse);
> + print_uint(PRINT_FP, NULL, " firstused %u sec",
> + (unsigned int)(tm->firstuse/hz));
> + }
The JSON should report in same units as non-json output.
If you are copying what expires does, it is wrong as well.
next prev parent reply other threads:[~2020-05-19 18:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 13:28 [PATCH iproute2-next 1/1] tc: report time an action was first used Roman Mashak
2020-05-18 13:10 ` Jamal Hadi Salim
2020-05-18 15:38 ` David Ahern
2020-05-19 9:09 ` Jamal Hadi Salim
2020-05-18 15:36 ` David Ahern
2020-05-18 16:41 ` Roman Mashak
2020-05-19 18:08 ` Stephen Hemminger
2020-05-19 18:09 ` David Ahern
2020-05-19 18:06 ` Stephen Hemminger [this message]
2020-05-19 18:11 ` David Ahern
2020-05-24 12:36 ` Roman Mashak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519110610.2c825a5c@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).