From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B70FC433DF for ; Wed, 20 May 2020 02:34:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1914220835 for ; Wed, 20 May 2020 02:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589942089; bh=5TX6blDXQ6f+6hKSGCxomiV/h9BfQhuTdQ1tm+sld0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=bFM1ApmdPdl8w6b6Bogdx7xohk1lFJLXAPL/kXim1GU1j+G3LoG1QYsS19vT9f882 GF6+/ESgWsHiSljJDg+g30sfcgwRSBqk1E21G3WIR4EWHM2swAbIvOHQWRlnSfkFGz oSs5PxyTBX3GQDh3seVqt1TD8LakhE5uYIYNphKA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728498AbgETCeq (ORCPT ); Tue, 19 May 2020 22:34:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:43258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726352AbgETCep (ORCPT ); Tue, 19 May 2020 22:34:45 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19D9F2075F; Wed, 20 May 2020 02:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589942085; bh=5TX6blDXQ6f+6hKSGCxomiV/h9BfQhuTdQ1tm+sld0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=klTWpgECYRftIP9DfV5mt0U3/nHgbW3YxUGGev8YNKgKYSbR6PX904dQj9BXy+wwR Z57gcVqNNDl8oZQ0XqQt4jR8uStgPIqDNn91m1Hty6nAQEazs44wW6mpqpznPL70Lr 2SM+1MGRt9qkjE38McwUKkvY60bdDnwI6cC1wIjI= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 0C7C740AFD; Tue, 19 May 2020 23:34:43 -0300 (-03) Date: Tue, 19 May 2020 23:34:43 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Kajol Jain , Andi Kleen , John Garry , Jin Yao , Kan Liang , Cong Wang , Kim Phillips , Adrian Hunter , Leo Yan , LKML , Networking , bpf , Stephane Eranian , Paul Clarke , Arnaldo Carvalho de Melo , Alexey Budankov Subject: Re: [PATCH v3 6/7] perf test: Improve pmu event metric testing Message-ID: <20200520023443.GE32678@kernel.org> References: <20200515221732.44078-1-irogers@google.com> <20200515221732.44078-7-irogers@google.com> <20200519190602.GB28228@kernel.org> <20200520011548.GD28228@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520011548.GD28228@kernel.org> X-Url: http://acmel.wordpress.com Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Em Tue, May 19, 2020 at 10:15:48PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, May 19, 2020 at 01:15:41PM -0700, Ian Rogers escreveu: > > On Tue, May 19, 2020 at 12:06 PM Arnaldo Carvalho de Melo > > errno != 0 for both cases as the man page notes suggest doing this. > > The tests using v are necessary to avoid the unused result, but > > presumably any errno case should return false here? I guess testing > > that is redundant as the return below will catch it. Perhaps this > > should be: > > > > errno = 0; > > v = strtod(str, &end_ptr); > > (void)v; /* We don't care for the value of the double, just that it > > converts. Avoid unused result warnings. */ > > return errno == 0 && end_ptr != str; > > Ok, I'll try that one. What I have is in my tmp.perf/core branch, this and the hashmap.h __WORDSIZE fixups, with those all the alpine Linux containers, that use Musl libc passed, waiting for the remaining 80 other containers to finish, now lots of these containers build with and without NO_LIBBPF=1 to make sure we test both variants, - Arnaldo