From: Ido Schimmel <idosch@idosch.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
petrm@mellanox.com, amitc@mellanox.com
Subject: Re: devlink interface for asynchronous event/messages from firmware?
Date: Fri, 22 May 2020 01:32:44 +0300 [thread overview]
Message-ID: <20200521223244.GA1104013@splinter> (raw)
In-Reply-To: <0d96e75a-64ee-b7be-786c-7015f65625a3@intel.com>
On Thu, May 21, 2020 at 03:09:57PM -0700, Jacob Keller wrote:
>
>
> On 5/21/2020 2:51 PM, Jakub Kicinski wrote:
> > On Thu, 21 May 2020 13:59:32 -0700 Jacob Keller wrote:
> >>>> So the ice firmware can optionally send diagnostic debug messages via
> >>>> its control queue. The current solutions we've used internally
> >>>> essentially hex-dump the binary contents to the kernel log, and then
> >>>> these get scraped and converted into a useful format for human consumption.
> >>>>
> >>>> I'm not 100% of the format, but I know it's based on a decoding file
> >>>> that is specific to a given firmware image, and thus attempting to tie
> >>>> this into the driver is problematic.
> >>>
> >>> You explained how it works, but not why it's needed :)
> >>
> >> Well, the reason we want it is to be able to read the debug/diagnostics
> >> data in order to debug issues that might be related to firmware or
> >> software mis-use of firmware interfaces.
> >>
> >> By having it be a separate interface rather than trying to scrape from
> >> the kernel message buffer, it becomes something we can have as a
> >> possibility for debugging in the field.
> >
> > For pure debug/tracing perhaps trace_devlink_hwerr() is the right fit?
> >
> > Right Ido?
> >
>
> Hm, yes that might be more suitable for this purpose. I'll take a look
> at it!
Jacob, here is more context that might help:
https://lore.kernel.org/netdev/20191103083554.6317-1-idosch@idosch.org/
https://lore.kernel.org/netdev/20191112064830.27002-1-idosch@idosch.org/
>
> Thanks,
> Jake
next prev parent reply other threads:[~2020-05-21 22:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 0:03 devlink interface for asynchronous event/messages from firmware? Jacob Keller
2020-05-21 0:16 ` Jakub Kicinski
2020-05-21 20:22 ` Jacob Keller
2020-05-21 20:52 ` Ido Schimmel
2020-05-21 20:59 ` Jacob Keller
2020-05-21 21:51 ` Jakub Kicinski
2020-05-21 22:09 ` Jacob Keller
2020-05-21 22:32 ` Ido Schimmel [this message]
2020-05-22 11:00 ` Jiri Pirko
2020-05-22 17:46 ` Jakub Kicinski
2020-05-26 21:13 ` Jacob Keller
2020-05-26 21:00 ` Jacob Keller
2020-05-22 11:03 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521223244.GA1104013@splinter \
--to=idosch@idosch.org \
--cc=amitc@mellanox.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).