From: David Miller <davem@davemloft.net>
To: dhowells@redhat.com
Cc: netdev@vger.kernel.org, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/3] rxrpc: Fix retransmission timeout and ACK discard
Date: Fri, 22 May 2020 15:54:18 -0700 (PDT) [thread overview]
Message-ID: <20200522.155418.406408375053374516.davem@davemloft.net> (raw)
In-Reply-To: <159001690181.18663.663730118645460940.stgit@warthog.procyon.org.uk>
From: David Howells <dhowells@redhat.com>
Date: Thu, 21 May 2020 00:21:42 +0100
>
> Here are a couple of fixes and an extra tracepoint for AF_RXRPC:
>
> (1) Calculate the RTO pretty much as TCP does, rather than making
> something up, including an initial 4s timeout (which causes return
> probes from the fileserver to fail if a packet goes missing), and add
> backoff.
>
> (2) Fix the discarding of out-of-order received ACKs. We mustn't let the
> hard-ACK point regress, nor do we want to do unnecessary
> retransmission because the soft-ACK list regresses. This is not
> trivial, however, due to some loose wording in various old protocol
> specs, the ACK field that should be used for this sometimes has the
> wrong information in it.
>
> (3) Add a tracepoint to log a discarded ACK.
>
> The patches are tagged here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
> rxrpc-fixes-20200520
Pulled, thanks David.
next prev parent reply other threads:[~2020-05-22 22:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 23:21 [PATCH net 0/3] rxrpc: Fix retransmission timeout and ACK discard David Howells
2020-05-20 23:21 ` [PATCH net 1/3] rxrpc: Fix the excessive initial retransmission timeout David Howells
2020-05-21 0:11 ` Jakub Kicinski
2020-05-20 23:21 ` [PATCH net 2/3] rxrpc: Trace discarded ACKs David Howells
2020-05-20 23:22 ` [PATCH net 3/3] rxrpc: Fix ack discard David Howells
2020-05-21 7:41 ` [PATCH net 0/3] rxrpc: Fix retransmission timeout and ACK discard David Howells
2020-05-22 22:54 ` David Miller [this message]
2020-05-22 23:26 ` David Howells
2020-05-22 23:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522.155418.406408375053374516.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox