From: David Miller <davem@davemloft.net>
To: olteanv@gmail.com
Cc: netdev@vger.kernel.org, allan.nielsen@microchip.com,
horatiu.vultur@microchip.com, andrew@lunn.ch,
f.fainelli@gmail.com, vivien.didelot@gmail.com,
joergen.andreasen@microchip.com, claudiu.manoil@nxp.com,
UNGLinuxDriver@microchip.com, alexandru.marginean@nxp.com,
xiaoliang.yang_1@nxp.com, yangbo.lu@nxp.com, po.liu@nxp.com
Subject: Re: [PATCH net] net: mscc: ocelot: fix address ageing time (again)
Date: Fri, 22 May 2020 16:16:01 -0700 (PDT) [thread overview]
Message-ID: <20200522.161601.1692050662918253992.davem@davemloft.net> (raw)
In-Reply-To: <20200521213123.672163-1-olteanv@gmail.com>
From: Vladimir Oltean <olteanv@gmail.com>
Date: Fri, 22 May 2020 00:31:23 +0300
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> ocelot_set_ageing_time has 2 callers:
> - felix_set_ageing_time: from drivers/net/dsa/ocelot/felix.c
> - ocelot_port_attr_ageing_set: from drivers/net/ethernet/mscc/ocelot.c
>
> The issue described in the fixed commit below actually happened for the
> felix_set_ageing_time code path only, since ocelot_port_attr_ageing_set
> was already dividing by 1000. So to make both paths symmetrical (and to
> fix addresses getting aged way too fast on Ocelot), stop dividing by
> 1000 at caller side altogether.
>
> Fixes: c0d7eccbc761 ("net: mscc: ocelot: ANA_AUTOAGE_AGE_PERIOD holds a value in seconds, not ms")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Applied.
prev parent reply other threads:[~2020-05-22 23:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 21:31 [PATCH net] net: mscc: ocelot: fix address ageing time (again) Vladimir Oltean
2020-05-22 23:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522.161601.1692050662918253992.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandru.marginean@nxp.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=joergen.andreasen@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=po.liu@nxp.com \
--cc=vivien.didelot@gmail.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).