From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07283C433E1 for ; Fri, 22 May 2020 15:10:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E304320671 for ; Fri, 22 May 2020 15:10:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730475AbgEVPKO (ORCPT ); Fri, 22 May 2020 11:10:14 -0400 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:56462 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729931AbgEVPKN (ORCPT ); Fri, 22 May 2020 11:10:13 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1jc9JK-0001rJ-BT; Fri, 22 May 2020 17:10:10 +0200 Date: Fri, 22 May 2020 17:10:10 +0200 From: Florian Westphal To: Paolo Abeni Cc: Florian Westphal , netdev@vger.kernel.org, matthieu.baerts@tessares.net, mathew.j.martineau@linux.intel.com Subject: Re: [PATCH net-next] mptcp: adjust tcp rcvspace after moving skbs from ssk to sk queue Message-ID: <20200522151010.GC26949@breakpoint.cc> References: <20200522124350.47615-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Paolo Abeni wrote: > It looks like this way ssk rcvbuf will grow up to tcp_rmem[2] even if > there is no user-space reader - assuming the link is fast enough. > > Don't we need to somehow cap that? e.g. moving mptcp rcvbuf update in > mptcp_revmsg()? >From irc discussion it looks like you already have a patch for that. I marked this patch as "Changes Requested" and do not plan to resend it for the time being.