From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C8BBC433DF for ; Tue, 26 May 2020 00:38:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0838206D5 for ; Tue, 26 May 2020 00:38:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388146AbgEZAi1 (ORCPT ); Mon, 25 May 2020 20:38:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726350AbgEZAi1 (ORCPT ); Mon, 25 May 2020 20:38:27 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F9BBC061A0E for ; Mon, 25 May 2020 17:38:27 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1A5D51278B453; Mon, 25 May 2020 17:38:23 -0700 (PDT) Date: Mon, 25 May 2020 17:38:18 -0700 (PDT) Message-Id: <20200525.173818.1886112260004012915.davem@davemloft.net> To: gnault@redhat.com Cc: kuba@kernel.org, netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@mellanox.com, benjamin.lahaise@netronome.com, tom@herbertland.com, pieter.jansenvanvuuren@netronome.com, pablo@netfilter.org, liels@mellanox.com, ronye@mellanox.com Subject: Re: [PATCH net-next v2 0/2] flow_dissector, cls_flower: Add support for multiple MPLS Label Stack Entries From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 25 May 2020 17:38:23 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Guillaume Nault Date: Thu, 21 May 2020 19:47:08 +0200 > Currently, the flow dissector and the Flower classifier can only handle > the first entry of an MPLS label stack. This patch series generalises > the code to allow parsing and matching the Label Stack Entries that > follow. > > Patch 1 extends the flow dissector to parse MPLS LSEs until the Bottom > Of Stack bit is reached. The number of parsed LSEs is capped at > FLOW_DIS_MPLS_MAX (arbitrarily set to 7). Flower and the NFP driver > are updated to take into account the new layout of struct > flow_dissector_key_mpls. > > Patch 2 extends Flower. It defines new netlink attributes, which are > independent from the previous MPLS ones. Mixing the old and the new > attributes in a same filter is not allowed. For backward compatibility, > the old attributes are used when dumping filters that don't require the > new ones. > > Changes since v1: > * Fix compilation of NFP driver (kbuild test robot). > * Fix sparse warning with entropy label (kbuild test robot). Series applied, thanks.