From: "Krzysztof Wilczyński" <kw@linux.com>
To: Alex Elder <elder@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-pci@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Pavel Machek <pavel@ucw.cz>,
linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
Kevin Hilman <khilman@kernel.org>,
Julian Wiedmann <jwi@linux.ibm.com>,
linux-acpi@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Len Brown <lenb@kernel.org>,
linux-pm@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Ursula Braun <ubraun@linux.ibm.com>,
Johan Hovold <johan@kernel.org>,
greybus-dev@lists.linaro.org,
John Stultz <john.stultz@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Felipe Balbi <balbi@kernel.org>, Alex Elder <elder@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Karsten Graul <kgraul@linux.ibm.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [greybus-dev] [PATCH 1/8] driver core: Add helper for accessing Power Management callbacs
Date: Tue, 26 May 2020 17:01:14 +0200 [thread overview]
Message-ID: <20200526150114.GB75990@rocinante> (raw)
In-Reply-To: <41c42552-0f4f-df6a-d587-5c62333aa6a8@linaro.org>
Hello Alex and Greg,
[...]
> This could just be:
>
> if (drv)
> return drv->pm;
>
> return NULL;
>
> Or if you want to evoke passion in Greg:
>
> return drv ? drv->pm : NULL;
>
> -Alex
>
> > I hate ? : lines with a passion, as they break normal pattern mattching
> > in my brain. Please just spell this all out:
> > if (drv && drv->pm)
> > return drv->pm;
> > return NULL;
> >
> > Much easier to read, and the compiler will do the exact same thing.
> >
> > Only place ? : are ok to use in my opinion, are as function arguments.
I will steer away from the ternary operator next time. Also, good to
learn about Greg's preference.
Thank you both!
Krzysztof
next prev parent reply other threads:[~2020-05-26 15:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 18:26 [PATCH 0/8] Add helper for accessing Power Management callbacs Krzysztof Wilczyński
2020-05-25 18:26 ` [PATCH 1/8] driver core: " Krzysztof Wilczyński
2020-05-26 6:33 ` Greg Kroah-Hartman
2020-05-26 11:53 ` [greybus-dev] " Alex Elder
2020-05-26 15:01 ` Krzysztof Wilczyński [this message]
2020-05-25 18:26 ` [PATCH 2/8] ACPI: PM: Use the new device_to_pm() helper to access struct dev_pm_ops Krzysztof Wilczyński
2020-05-26 8:37 ` Rafael J. Wysocki
2020-05-26 9:45 ` Pavel Machek
2020-05-26 10:35 ` Rafael J. Wysocki
2020-05-25 18:26 ` [PATCH 3/8] greybus: " Krzysztof Wilczyński
2020-05-26 11:53 ` [greybus-dev] " Alex Elder
2020-05-25 18:26 ` [PATCH 4/8] scsi: pm: " Krzysztof Wilczyński
2020-05-25 18:26 ` [PATCH 5/8] usb: phy: fsl: " Krzysztof Wilczyński
2020-05-26 8:38 ` Rafael J. Wysocki
2020-05-25 18:26 ` [PATCH 6/8] PCI/PM: " Krzysztof Wilczyński
2020-05-25 18:26 ` [PATCH 7/8] PM: " Krzysztof Wilczyński
2020-05-26 8:33 ` Rafael J. Wysocki
2020-05-25 18:26 ` [PATCH 8/8] net/iucv: " Krzysztof Wilczyński
2020-05-26 6:35 ` Greg Kroah-Hartman
2020-05-26 15:07 ` Krzysztof Wilczyński
2020-05-26 15:19 ` Rafael J. Wysocki
2020-05-26 15:28 ` Alan Stern
2020-05-26 16:06 ` Rafael J. Wysocki
2020-05-26 16:48 ` [greybus-dev] " Alex Elder
2020-05-26 7:07 ` Ursula Braun
2020-05-26 14:57 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526150114.GB75990@rocinante \
--to=kw@linux.com \
--cc=balbi@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=elder@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jejb@linux.ibm.com \
--cc=johan@kernel.org \
--cc=john.stultz@linaro.org \
--cc=jwi@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=khilman@kernel.org \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=ubraun@linux.ibm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).