From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org, matthieu.baerts@tessares.net,
mathew.j.martineau@linux.intel.com, pabeni@redhat.com
Subject: Re: [PATCH v2 net-next 0/2] mptcp: adjust tcp rcvspace on rx
Date: Wed, 27 May 2020 11:29:31 -0700 (PDT) [thread overview]
Message-ID: <20200527.112931.1797611080625540455.davem@davemloft.net> (raw)
In-Reply-To: <20200527115545.GH2915@breakpoint.cc>
From: Florian Westphal <fw@strlen.de>
Date: Wed, 27 May 2020 13:55:45 +0200
> David Miller <davem@davemloft.net> wrote:
>> From: Florian Westphal <fw@strlen.de>
>> Date: Mon, 25 May 2020 20:15:06 +0200
>>
>> > These two patches improve mptcp throughput by making sure tcp grows
>> > the receive buffer when we move skbs from subflow socket to the
>> > mptcp socket.
>> >
>> > The second patch moves mptcp receive buffer increase to the recvmsg
>> > path, i.e. we only change its size when userspace processes/consumes
>> > the data. This is done by using the largest rcvbuf size of the active
>> > subflows.
>>
>> What's the follow-up wrt. Christoph's feedback on patch #2?
>
> Please drop these patches, I have no idea (yet?) how to address it.
Ok, thank you.
prev parent reply other threads:[~2020-05-27 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 18:15 [PATCH v2 net-next 0/2] mptcp: adjust tcp rcvspace on rx Florian Westphal
2020-05-25 18:15 ` [PATCH v2 net-next 1/2] mptcp: adjust tcp rcvspace after moving skbs from ssk to sk queue Florian Westphal
2020-05-25 18:15 ` [PATCH v2 net-next 2/2] mptcp: move recbuf adjustment to recvmsg path Florian Westphal
2020-05-26 16:07 ` Christoph Paasch
2020-05-27 11:55 ` Florian Westphal
2020-05-27 3:28 ` [PATCH v2 net-next 0/2] mptcp: adjust tcp rcvspace on rx David Miller
2020-05-27 11:55 ` Florian Westphal
2020-05-27 18:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527.112931.1797611080625540455.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).