From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBD8BC433DF for ; Wed, 27 May 2020 02:54:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0361207D3 for ; Wed, 27 May 2020 02:54:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590548073; bh=iobn6UAMLhlS4rd0Hoku5ofXoZ4xvWgXEA28d9pI2xw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Gb4bmWAHc7AF3hc5rsK93UgRbc4ImFm/El7Y3ewjlL4Dot84lfkzeJSX/YxfxmUmS us1FhPUWRtlgPDUPsy44KEGkZw885xDxrU4T9JIofsU18lnrY7SR1uvgcjBpJ0WHKp RLuITfJzNk3DMhflg+UbTdTgU0SNoMUb9JLQWSC8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728191AbgE0Cyc (ORCPT ); Tue, 26 May 2020 22:54:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:49482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbgE0Cyc (ORCPT ); Tue, 26 May 2020 22:54:32 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A0B22075F; Wed, 27 May 2020 02:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590548071; bh=iobn6UAMLhlS4rd0Hoku5ofXoZ4xvWgXEA28d9pI2xw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RuFvhdYG9bFFWXzoVX0X6V1+nicrOsfFmBhCKX9WczeD697OjxjjfWuIebCB5E3ZZ QhrtgadvkBAH0crZT+vpc8Qt/ECgV+STynVX2ECC0MophCS4LMlg7egZ09uQIp4lbS LvtBx1WZf7okz1+KnCJGf/em5MNjWm+LQ/lYtXsY= Date: Wed, 27 May 2020 05:54:28 +0300 From: Leon Romanovsky To: Jason Gunthorpe Cc: Doug Ledford , linux-rdma@vger.kernel.org, Maor Gottlieb , Mark Zhang , netdev@vger.kernel.org, Saeed Mahameed Subject: Re: [PATCH rdma-next v3 0/8] Driver part of the ECE Message-ID: <20200527025428.GG100179@unreal> References: <20200526115440.205922-1-leon@kernel.org> <20200526190419.GA18519@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200526190419.GA18519@ziepe.ca> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, May 26, 2020 at 04:04:20PM -0300, Jason Gunthorpe wrote: > On Tue, May 26, 2020 at 02:54:32PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Changelog: > > v3: > > * Squashed patch "RDMA/mlx5: Advertise ECE support" into > > "RDMA/mlx5: Set ECE options during modify QP". > > v2: > > https://lore.kernel.org/linux-rdma/20200525174401.71152-1-leon@kernel.org > > * Rebased on latest wip/jgg-rdma-next branch, commit a94dae867c56 > > * Fixed wrong setting of pm_state field in mlx5 conversion patch > > * Removed DC support for now > > v1: > > https://lore.kernel.org/linux-rdma/20200523132243.817936-1-leon@kernel.org > > * Fixed compatibility issue of "old" kernel vs. "new" rdma-core. This > > is handled in extra patch. > > * Improved comments and commit messages after feedback from Yishai. > > * Added Mark Z. ROB tags > > v0: > > https://lore.kernel.org/linux-rdma/20200520082919.440939-1-leon@kernel.org > > > > > > Hi, > > > > This is driver part of the RDMA-CM ECE series [1]. > > According to the IBTA, ECE data is completely vendor specific, so this > > series extends mlx5_ib create_qp and modify_qp structs with extra field > > to pass ECE options to/from the application. > > > > Thanks > > > > [1] > > https://lore.kernel.org/linux-rdma/20200413141538.935574-1-leon@kernel.org > > > > Leon Romanovsky (8): > > net/mlx5: Add ability to read and write ECE options > > RDMA/mlx5: Get ECE options from FW during create QP > > RDMA/mlx5: Set ECE options during QP create > > RDMA/mlx5: Use direct modify QP implementation > > RDMA/mlx5: Remove manually crafted QP context the query call > > RDMA/mlx5: Convert modify QP to use MLX5_SET macros > > RDMA/mlx5: Set ECE options during modify QP > > RDMA/mlx5: Return ECE data after modify QP > > It seems fine, can you add the one patch to the shared branch please First patch is applied to the mlx5-next. f55ece0e11c1 net/mlx5: Add ability to read and write ECE options Thanks > > Thanks, > Jason