From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrea Claudi <aclaudi@redhat.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com, jhs@mojatatu.com
Subject: Re: [iproute2 PATCH 0/2] Fix segfault in lib/bpf.c
Date: Wed, 27 May 2020 15:13:35 -0700 [thread overview]
Message-ID: <20200527151335.33ae7e9a@hermes.lan> (raw)
In-Reply-To: <cover.1590508215.git.aclaudi@redhat.com>
On Tue, 26 May 2020 18:04:09 +0200
Andrea Claudi <aclaudi@redhat.com> wrote:
> Jamal reported a segfault in bpf_make_custom_path() when custom pinning is
> used. This is caused by commit c0325b06382cb ("bpf: replace snprintf with
> asprintf when dealing with long buffers").
>
> As the only goal of that commit is to get rid of a truncation warning when
> compiling lib/bpf.c, revert it and fix the warning checking for snprintf
> return value
>
> Andrea Claudi (2):
> Revert "bpf: replace snprintf with asprintf when dealing with long
> buffers"
> bpf: Fixes a snprintf truncation warning
>
> lib/bpf.c | 155 +++++++++++++++---------------------------------------
> 1 file changed, 41 insertions(+), 114 deletions(-)
>
ok merged
next prev parent reply other threads:[~2020-05-27 22:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 16:04 [iproute2 PATCH 0/2] Fix segfault in lib/bpf.c Andrea Claudi
2020-05-26 16:04 ` [iproute2 PATCH 1/2] Revert "bpf: replace snprintf with asprintf when dealing with long buffers" Andrea Claudi
2020-05-26 16:04 ` [iproute2 PATCH 2/2] bpf: Fixes a snprintf truncation warning Andrea Claudi
2020-05-26 21:27 ` [iproute2 PATCH 0/2] Fix segfault in lib/bpf.c Daniel Borkmann
2020-05-27 22:13 ` Stephen Hemminger [this message]
2020-05-28 11:14 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527151335.33ae7e9a@hermes.lan \
--to=stephen@networkplumber.org \
--cc=aclaudi@redhat.com \
--cc=dsahern@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).