From: Jesper Dangaard Brouer <brouer@redhat.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: David Ahern <dsahern@gmail.com>, David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
daniel@iogearbox.net, john.fastabend@gmail.com, ast@kernel.org,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com, andriin@fb.com,
brouer@redhat.com
Subject: Re: [PATCH bpf-next 4/5] bpftool: Add SEC name for xdp programs attached to device map
Date: Wed, 27 May 2020 17:43:18 +0200 [thread overview]
Message-ID: <20200527174318.38aa5e2d@carbon> (raw)
In-Reply-To: <87o8q91ky1.fsf@toke.dk>
On Wed, 27 May 2020 17:01:10 +0200
Toke Høiland-Jørgensen <toke@redhat.com> wrote:
> David Ahern <dsahern@gmail.com> writes:
>
> > On 5/27/20 4:02 AM, Toke Høiland-Jørgensen wrote:
> >> David Ahern <dsahern@kernel.org> writes:
> >>
> >>> Support SEC("xdp_dm*") as a short cut for loading the program with
> >>> type BPF_PROG_TYPE_XDP and expected attach type BPF_XDP_DEVMAP.
> >>
> >> You're not using this in the selftest; shouldn't you be? Also, the
> >> prefix should be libbpf: not bpftool:, no?
> >>
> >
> > The selftest is exercising kernel APIs - what is allowed and what is
> > not.
>
> Sure, but they also de facto serve as example code for features that are
> not documented anywhere else, so just seemed a bit odd to me that you
> were not using this to mark the programs.
>
> Anyway, not going to insist if you prefer explicitly setting
> expected_attach_type...
I actually think that it is better to demonstrate that it is possible to set:
attr.expected_attach_type = BPF_XDP_DEVMAP;
Because people will be grepping the source code to find examples ;-)
We could add a comment, that say SEC("xdp_dm") can be used as short cut.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-05-27 15:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 1:09 [PATCH bpf-next 0/5] bpf: Add support for XDP programs in DEVMAP entries David Ahern
2020-05-27 1:09 ` [PATCH bpf-next 1/5] bpf: Handle 8-byte values in DEVMAP and DEVMAP_HASH David Ahern
2020-05-27 10:26 ` Jesper Dangaard Brouer
2020-05-27 13:56 ` David Ahern
2020-05-27 14:57 ` Toke Høiland-Jørgensen
2020-05-27 15:24 ` David Ahern
2020-05-27 14:27 ` David Ahern
2020-05-27 15:30 ` Jesper Dangaard Brouer
2020-05-27 18:38 ` David Ahern
2020-05-27 1:09 ` [PATCH bpf-next 2/5] bpf: Add support to attach bpf program to a devmap entry David Ahern
2020-05-27 10:01 ` Toke Høiland-Jørgensen
2020-05-27 14:02 ` David Ahern
2020-05-27 14:58 ` Toke Høiland-Jørgensen
2020-05-27 1:09 ` [PATCH bpf-next 3/5] xdp: Add xdp_txq_info to xdp_buff David Ahern
2020-05-27 1:09 ` [PATCH bpf-next 4/5] bpftool: Add SEC name for xdp programs attached to device map David Ahern
2020-05-27 10:02 ` Toke Høiland-Jørgensen
2020-05-27 14:03 ` David Ahern
2020-05-27 15:01 ` Toke Høiland-Jørgensen
2020-05-27 15:43 ` Jesper Dangaard Brouer [this message]
2020-05-27 1:09 ` [PATCH bpf-next 5/5] selftest: Add tests for XDP programs in devmap entries David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527174318.38aa5e2d@carbon \
--to=brouer@redhat.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox