From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports
Date: Thu, 28 May 2020 14:07:38 +0100 [thread overview]
Message-ID: <20200528130738.GT1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200528121121.125189-1-tbogendoerfer@suse.de>
On Thu, May 28, 2020 at 02:11:21PM +0200, Thomas Bogendoerfer wrote:
> Commit d14e078f23cc ("net: marvell: mvpp2: only reprogram what is necessary
> on mac_config") disabled auto negotiation bypass completely, which breaks
> platforms enabling bypass via firmware (not the best option, but it worked).
> Since 1000BaseX/2500BaseX ports neither negotiate speed nor duplex mode
> we could enable auto negotiation bypass to get back information about link
> state.
Thanks, but your commit is missing some useful information.
Which platforms have broken?
Can you describe the situation where you require this bit to be set?
We should not be enabling bypass mode as a matter of course, it exists
to work around broken setups which do not send the control word.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up
next prev parent reply other threads:[~2020-05-28 13:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 12:11 [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports Thomas Bogendoerfer
2020-05-28 13:07 ` Russell King - ARM Linux admin [this message]
2020-05-28 13:17 ` Thomas Bogendoerfer
2020-05-28 13:56 ` Russell King - ARM Linux admin
2020-05-28 14:33 ` Thomas Bogendoerfer
2020-05-28 14:48 ` Russell King - ARM Linux admin
2020-05-28 18:43 ` Thomas Bogendoerfer
2020-05-28 20:15 ` Andrew Lunn
2020-05-28 22:04 ` Russell King - ARM Linux admin
2020-05-29 11:05 ` Thomas Bogendoerfer
2020-05-29 14:59 ` Andrew Lunn
2020-05-29 15:51 ` Russell King - ARM Linux admin
2020-05-29 16:25 ` Andrew Lunn
2020-05-29 17:02 ` Russell King - ARM Linux admin
2020-05-29 15:52 ` Thomas Bogendoerfer
2020-05-29 16:33 ` Andrew Lunn
2020-06-02 8:08 ` Thomas Bogendoerfer
2020-06-02 22:50 ` Russell King - ARM Linux admin
2020-06-03 12:31 ` Russell King - ARM Linux admin
2020-06-03 13:21 ` Andrew Lunn
2020-06-03 14:58 ` Russell King - ARM Linux admin
2020-05-28 16:33 ` Andrew Lunn
2020-05-28 18:43 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528130738.GT1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tbogendoerfer@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).