From: David Miller <davem@davemloft.net>
To: olteanv@gmail.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: sja1105: fix port mirroring for P/Q/R/S
Date: Fri, 29 May 2020 16:45:06 -0700 (PDT) [thread overview]
Message-ID: <20200529.164506.2200622965835884094.davem@davemloft.net> (raw)
In-Reply-To: <20200527164006.1080903-1-olteanv@gmail.com>
From: Vladimir Oltean <olteanv@gmail.com>
Date: Wed, 27 May 2020 19:40:06 +0300
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> The dynamic configuration interface for the General Params and the L2
> Lookup Params tables was copy-pasted between E/T devices and P/Q/R/S
> devices. Nonetheless, these interfaces are bitwise different (and not to
> mention, located at different SPI addresses).
>
> The driver is using dynamic reconfiguration of the General Parameters
> table for the port mirroring feature, which was therefore broken on
> P/Q/R/S.
>
> Note that I don't think this patch can be backported very far to stable
> trees (since it conflicts with some other development done since the
> introduction of the driver).
>
> Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Please fix the build errors reported by the kbuild robot.
next prev parent reply other threads:[~2020-05-29 23:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 16:40 [PATCH net] net: dsa: sja1105: fix port mirroring for P/Q/R/S Vladimir Oltean
2020-05-29 2:56 ` kbuild test robot
2020-05-29 19:33 ` kbuild test robot
2020-05-29 23:45 ` David Miller [this message]
2020-05-30 10:33 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529.164506.2200622965835884094.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).