From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F15C433DF for ; Fri, 29 May 2020 14:29:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B065A2073B for ; Fri, 29 May 2020 14:29:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="NnVhRDvY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726993AbgE2O3x (ORCPT ); Fri, 29 May 2020 10:29:53 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:56826 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726849AbgE2O3x (ORCPT ); Fri, 29 May 2020 10:29:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=k/LsmBn8OkC7ApnYXMt3CU61fMHpdk7RjDwpBDBoSD4=; b=NnVhRDvYFINJjkqRJKi4YgHoQO kAeOXPGjTaUw3SYL/krwmQfIMpWvIGsMiycKOGjBBig67OEdNQcTx1c9XSR5r+oGphk0X1WbMSE8I xi3aED7NpRXMuMDkkR7aNagWWTiKMRbvrnOYIAsDwg1IEgzKRelCubQbiL4s6FCOzJzM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jeg19-003eV2-RB; Fri, 29 May 2020 16:29:51 +0200 Date: Fri, 29 May 2020 16:29:51 +0200 From: Andrew Lunn To: Michal Kubecek Cc: John Linville , netdev@vger.kernel.org, Oleksij Rempel Subject: Re: [PATCH ethtool 03/21] netlink: fix msgbuff_append() helper Message-ID: <20200529142951.GE869823@lunn.ch> References: <065379b5682ce800f8631bc97bc69b2421d143b7.1590707335.git.mkubecek@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <065379b5682ce800f8631bc97bc69b2421d143b7.1590707335.git.mkubecek@suse.cz> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, May 29, 2020 at 01:21:22AM +0200, Michal Kubecek wrote: > As msgbuff_append() only copies protocol payload, i.e. part of the buffer > without netlink and genetlink header, and mnl_nlmsg_get_payload_len() only > subtracts netlink header length, we need to subtract genetlink header > length manually to get correct length of appended data block. > > Fixes: 5050607946b6 ("netlink: message buffer and composition helpers") > Reported-by: Andrew Lunn > Signed-off-by: Michal Kubecek Tested-by: Andrew Lunn Andrew