* [PATCH] atmel: Use shared constant for rfc1042 header
@ 2020-05-23 21:27 Pascal Terjan
2020-05-29 17:16 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Pascal Terjan @ 2020-05-23 21:27 UTC (permalink / raw)
To: Simon Kelley, Kalle Valo, David S. Miller, Jakub Kicinski,
linux-wireless, netdev, linux-kernel
Cc: Pascal Terjan
This is one of the 9 drivers redefining rfc1042_header.
Signed-off-by: Pascal Terjan <pterjan@google.com>
---
drivers/net/wireless/atmel/atmel.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/atmel/atmel.c b/drivers/net/wireless/atmel/atmel.c
index 74538085cfb7..d5875836068c 100644
--- a/drivers/net/wireless/atmel/atmel.c
+++ b/drivers/net/wireless/atmel/atmel.c
@@ -798,7 +798,6 @@ static void tx_update_descriptor(struct atmel_private *priv, int is_bcast,
static netdev_tx_t start_tx(struct sk_buff *skb, struct net_device *dev)
{
- static const u8 SNAP_RFC1024[6] = { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 };
struct atmel_private *priv = netdev_priv(dev);
struct ieee80211_hdr header;
unsigned long flags;
@@ -853,7 +852,7 @@ static netdev_tx_t start_tx(struct sk_buff *skb, struct net_device *dev)
}
if (priv->use_wpa)
- memcpy(&header.addr4, SNAP_RFC1024, ETH_ALEN);
+ memcpy(&header.addr4, rfc1042_header, ETH_ALEN);
header.frame_control = cpu_to_le16(frame_ctl);
/* Copy the wireless header into the card */
--
2.27.0.rc0.183.gde8f92d652-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] atmel: Use shared constant for rfc1042 header
2020-05-23 21:27 [PATCH] atmel: Use shared constant for rfc1042 header Pascal Terjan
@ 2020-05-29 17:16 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-05-29 17:16 UTC (permalink / raw)
To: Pascal Terjan
Cc: Simon Kelley, David S. Miller, Jakub Kicinski, linux-wireless,
netdev, linux-kernel, Pascal Terjan
Pascal Terjan <pterjan@google.com> wrote:
> This is one of the 9 drivers redefining rfc1042_header.
>
> Signed-off-by: Pascal Terjan <pterjan@google.com>
Patch applied to wireless-drivers-next.git, thanks.
e78e5d18c653 atmel: Use shared constant for rfc1042 header
--
https://patchwork.kernel.org/patch/11567013/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-29 17:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-23 21:27 [PATCH] atmel: Use shared constant for rfc1042 header Pascal Terjan
2020-05-29 17:16 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).