From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24ACCC433E1 for ; Fri, 29 May 2020 17:32:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED40E207BC for ; Fri, 29 May 2020 17:32:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="UZGPys+C" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727101AbgE2RcJ (ORCPT ); Fri, 29 May 2020 13:32:09 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:29468 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726970AbgE2Rbc (ORCPT ); Fri, 29 May 2020 13:31:32 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1590773491; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=6F9CNHe8Qpy8XEgxu8ud42/OjS8EjONkBKKX5sjGnLI=; b=UZGPys+CS+A3Wa0f/IHYUmCsNeWqYLWnvVnT93p2zNaYals9/MU0TjFDsDnx9ryYTOHcazco 83wMpwYAxOkEq85N2JzfQ8qYFOfeCGB/7lloiPkZbwluNwMnkAMV80Y06gkgE//17Y4HtXda GQ7TqDYVLgbufoa+2nt9RxvhDq4= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 5ed146eabf0e32d254900ee3 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 29 May 2020 17:31:22 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CF15FC433CA; Fri, 29 May 2020 17:31:22 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 11E40C433C9; Fri, 29 May 2020 17:31:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 11E40C433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wlcore: fix runtime pm imbalance in wl1271_tx_work From: Kalle Valo In-Reply-To: <20200520124241.9931-1-dinghao.liu@zju.edu.cn> References: <20200520124241.9931-1-dinghao.liu@zju.edu.cn> To: Dinghao Liu Cc: dinghao.liu@zju.edu.cn, kjlu@umn.edu, "David S. Miller" , Jakub Kicinski , Thomas Gleixner , Arnd Bergmann , Greg Kroah-Hartman , Allison Randal , Alexios Zavras , "Jason A. Donenfeld" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200529173122.CF15FC433CA@smtp.codeaurora.org> Date: Fri, 29 May 2020 17:31:22 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dinghao Liu wrote: > There are two error handling paths in this functon. When > wlcore_tx_work_locked() returns an error code, we should > decrease the runtime PM usage counter the same way as the > error handling path beginning from pm_runtime_get_sync(). > > Signed-off-by: Dinghao Liu > Acked-by: Tony Lindgren Patch applied to wireless-drivers-next.git, thanks. 9604617e998b wlcore: fix runtime pm imbalance in wl1271_tx_work -- https://patchwork.kernel.org/patch/11560387/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches