From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
jchapman@katalix.com, gnault@redhat.com,
syzkaller@googlegroups.com
Subject: Re: [PATCH net] l2tp: add sk_family checks to l2tp_validate_socket
Date: Sat, 30 May 2020 21:57:47 -0700 (PDT) [thread overview]
Message-ID: <20200530.215747.1590223834792811961.davem@davemloft.net> (raw)
In-Reply-To: <20200529183225.150288-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Fri, 29 May 2020 11:32:25 -0700
> syzbot was able to trigger a crash after using an ISDN socket
> and fool l2tp.
>
> Fix this by making sure the UDP socket is of the proper family.
...
> Fixes: 6b9f34239b00 ("l2tp: fix races in tunnel creation")
> Fixes: fd558d186df2 ("l2tp: Split pppol2tp patch into separate l2tp and ppp parts")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: James Chapman <jchapman@katalix.com>
> Cc: Guillaume Nault <gnault@redhat.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2020-05-31 4:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 18:32 [PATCH net] l2tp: add sk_family checks to l2tp_validate_socket Eric Dumazet
2020-05-30 15:51 ` Guillaume Nault
2020-05-31 4:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200530.215747.1590223834792811961.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=gnault@redhat.com \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox