From: Stephen Hemminger <stephen@networkplumber.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/6] r8169: change driver data type
Date: Sat, 30 May 2020 22:17:17 -0700 [thread overview]
Message-ID: <20200530221717.400033de@hermes.lan> (raw)
In-Reply-To: <29eabcd4-fd77-58f8-3091-acc607949e28@gmail.com>
On Sat, 30 May 2020 23:54:36 +0200
Heiner Kallweit <hkallweit1@gmail.com> wrote:
> Change driver private data type to struct rtl8169_private * to avoid
> some overhead.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
Are you sure about this. Using netdev_priv() is actually at a fixed
offset from netdev, and almost always the compiler can optimize and
use one register. Look at the assembly code difference of what you
did.
next prev parent reply other threads:[~2020-05-31 5:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 21:52 [PATCH net-next 0/6] r8169: again few improvements Heiner Kallweit
2020-05-30 21:54 ` [PATCH net-next 1/6] r8169: change driver data type Heiner Kallweit
2020-05-31 5:17 ` Stephen Hemminger [this message]
2020-05-31 7:57 ` Heiner Kallweit
2020-05-30 21:55 ` [PATCH net-next 2/6] r8169: enable WAKE_PHY as only WoL source when runtime-suspending Heiner Kallweit
2020-05-30 21:56 ` [PATCH net-next 3/6] r8169: don't reset tx ring indexes in rtl8169_tx_clear Heiner Kallweit
2020-05-30 21:57 ` [PATCH net-next 4/6] r8169: move some calls to rtl8169_hw_reset Heiner Kallweit
2020-05-30 21:58 ` [PATCH net-next 5/6] r8169: make rtl8169_down central chip quiesce function Heiner Kallweit
2020-05-30 21:59 ` [PATCH net-next 6/6] r8169: improve handling power management ops Heiner Kallweit
2020-05-31 4:37 ` [PATCH net-next 0/6] r8169: again few improvements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200530221717.400033de@hermes.lan \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).