From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3497C433E1 for ; Mon, 1 Jun 2020 18:42:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D874206A4 for ; Mon, 1 Jun 2020 18:42:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731583AbgFASmq (ORCPT ); Mon, 1 Jun 2020 14:42:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731512AbgFASmo (ORCPT ); Mon, 1 Jun 2020 14:42:44 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D657C00863D; Mon, 1 Jun 2020 11:33:52 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D4D8E11D53F8B; Mon, 1 Jun 2020 11:33:51 -0700 (PDT) Date: Mon, 01 Jun 2020 11:33:51 -0700 (PDT) Message-Id: <20200601.113351.412390872566987442.davem@davemloft.net> To: dan.carpenter@oracle.com Cc: vishal@chelsio.com, kuba@kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] cxgb4: cleanup error code in setup_sge_queues_uld() From: David Miller In-Reply-To: <20200528124957.GD1219412@mwanda> References: <20200528124957.GD1219412@mwanda> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Jun 2020 11:33:52 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dan Carpenter Date: Thu, 28 May 2020 15:49:57 +0300 > The caller doesn't care about the error codes, they only check for zero > vs non-zero. Still, it's better to preserve the negative error codes > from alloc_uld_rxqs() instead of changing it to 1. We can also return > directly if there is a failure. > > Signed-off-by: Dan Carpenter Applied.