From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Alexandru Marginean <alexandru.marginean@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
"Madalin Bucur (OSS)" <madalin.bucur@oss.nxp.com>,
radu-andrei.bulie@nxp.com, fido_max@inbox.ru
Subject: Re: [PATCH v3 net-next 01/13] regmap: add helper for per-port regfield initialization
Date: Mon, 1 Jun 2020 13:51:31 +0200 [thread overview]
Message-ID: <20200601115131.GA3720@piout.net> (raw)
In-Reply-To: <CA+h21hqp92JBchpesxT8spZs7P7nmW_Vf0tev_Li4hjWw2_vUw@mail.gmail.com>
On 01/06/2020 14:12:38+0300, Vladimir Oltean wrote:
> Hi Mark,
>
> On Mon, 1 Jun 2020 at 13:54, Mark Brown <broonie@kernel.org> wrote:
> >
> > On Sun, May 31, 2020 at 03:26:28PM +0300, Vladimir Oltean wrote:
> > > From: Vladimir Oltean <vladimir.oltean@nxp.com>
> > >
> > > Similar to the standalone regfields, add an initializer for the users
> > > who need to set .id_size and .id_offset in order to use the
> > > regmap_fields_update_bits_base API.
> > >
> > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > > Link: https://lore.kernel.org/r/20200527234113.2491988-2-olteanv@gmail.com
> > > Signed-off-by: Mark Brown <broonie@kernel.org>
> >
> > Please either just wait till after the merge window or ask for a pull
> > request like I said when I applied the patch.
>
> The trouble with waiting is that I'll then have to wait for another
> release cycle until I can send device tree patches to Shawn Guo's
> devicetree branch. So this seemed to me as the path of least friction.
You can actually have the device tree changes and the driver changes in
the same release as there is no build time dependency.
> In my mind I am not exactly sure what the pull request does to improve
> the work flow. My simplified idea was that you would send a pull
> request upstream, then David would send a pull request upstream (or
> the other way around), and poof, this common commit would disappear
> from one of the pull requests.
No, this would make you commit appear twice in the history with
different hashes. If you want to have what you suggest, Dave needs to
first take Mark's PR so both PR will have the same commit hash.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-06-01 11:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 12:26 [PATCH v3 net-next 00/13] New DSA driver for VSC9953 Seville switch Vladimir Oltean
2020-05-31 12:26 ` [PATCH v3 net-next 01/13] regmap: add helper for per-port regfield initialization Vladimir Oltean
2020-06-01 10:54 ` Mark Brown
2020-06-01 11:12 ` Vladimir Oltean
2020-06-01 11:51 ` Alexandre Belloni [this message]
2020-06-01 12:50 ` Mark Brown
2020-05-31 12:26 ` [PATCH v3 net-next 02/13] net: dsa: felix: set proper link speed in felix_phylink_mac_config Vladimir Oltean
2020-05-31 12:26 ` [PATCH v3 net-next 03/13] net: mscc: ocelot: convert port registers to regmap Vladimir Oltean
2020-05-31 12:26 ` [PATCH v3 net-next 04/13] soc/mscc: ocelot: add MII registers description Vladimir Oltean
2020-05-31 12:26 ` [PATCH v3 net-next 05/13] net: mscc: ocelot: convert QSYS_SWITCH_PORT_MODE and SYS_PORT_MODE to regfields Vladimir Oltean
2020-05-31 12:26 ` [PATCH v3 net-next 06/13] net: dsa: felix: create a template for the DSA tags on xmit Vladimir Oltean
2020-05-31 12:26 ` [PATCH v3 net-next 07/13] net: mscc: ocelot: split writes to pause frame enable bit and to thresholds Vladimir Oltean
2020-05-31 12:26 ` [PATCH v3 net-next 08/13] net: mscc: ocelot: disable flow control on NPI interface Vladimir Oltean
2020-05-31 12:26 ` [PATCH v3 net-next 09/13] net: mscc: ocelot: convert SYS_PAUSE_CFG register access to regfield Vladimir Oltean
2020-05-31 12:26 ` [PATCH v3 net-next 10/13] net: mscc: ocelot: extend watermark encoding function Vladimir Oltean
2020-05-31 12:26 ` [PATCH v3 net-next 11/13] net: dsa: felix: support half-duplex link modes Vladimir Oltean
2020-05-31 12:26 ` [PATCH v3 net-next 12/13] net: dsa: felix: move probing to felix_vsc9959.c Vladimir Oltean
2020-06-01 21:14 ` Jakub Kicinski
2020-05-31 12:26 ` [PATCH v3 net-next 13/13] net: dsa: felix: introduce support for Seville VSC9953 switch Vladimir Oltean
2020-06-01 21:14 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601115131.GA3720@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandru.marginean@nxp.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=broonie@kernel.org \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=fido_max@inbox.ru \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=radu-andrei.bulie@nxp.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).