From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1442C433E1 for ; Tue, 2 Jun 2020 08:13:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C582F2077D for ; Tue, 2 Jun 2020 08:13:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aNi1/+/Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726093AbgFBINx (ORCPT ); Tue, 2 Jun 2020 04:13:53 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:28373 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725811AbgFBINw (ORCPT ); Tue, 2 Jun 2020 04:13:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591085631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jKAG7zojW7jlju7CxcnAk+lwgOINaIpv7z+cKAhjErs=; b=aNi1/+/ZmKhZ5A7hSAWx4jNmuC+kS9K0Znl4oziWj8Ogj/AgwmAwvWolxG1UzX4zzvRRNj qgMjcQWXj+H8q+GmqT0fJQNCCfUnXOIPnZsOpFfJRRu6aFRCPnuLmGkYbUvGRguPbjOPpV 7Wq1EzOkIbTcuh2hbR77rinuINUlB7E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-267-LYYUxxwnMoO3sfugYEMIzQ-1; Tue, 02 Jun 2020 04:13:46 -0400 X-MC-Unique: LYYUxxwnMoO3sfugYEMIzQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E85DE461; Tue, 2 Jun 2020 08:13:43 +0000 (UTC) Received: from krava (unknown [10.40.195.39]) by smtp.corp.redhat.com (Postfix) with SMTP id 5417C7E7E6; Tue, 2 Jun 2020 08:13:40 +0000 (UTC) Date: Tue, 2 Jun 2020 10:13:39 +0200 From: Jiri Olsa To: Alexei Starovoitov Cc: Song Liu , Jiri Olsa , Alexei Starovoitov , Daniel Borkmann , KP Singh , Networking , bpf , Yonghong Song , Martin KaFai Lau , Jakub Kicinski , David Miller , John Fastabend , Jesper Dangaard Brouer , Andrii Nakryiko , KP Singh Subject: Re: [PATCH] bpf: Use tracing helpers for lsm programs Message-ID: <20200602081339.GA1112120@krava> References: <20200531154255.896551-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 01, 2020 at 03:12:13PM -0700, Alexei Starovoitov wrote: > On Mon, Jun 1, 2020 at 12:00 PM Song Liu wrote: > > > > On Sun, May 31, 2020 at 8:45 AM Jiri Olsa wrote: > > > > > > Currenty lsm uses bpf_tracing_func_proto helpers which do > > > not include stack trace or perf event output. It's useful > > > to have those for bpftrace lsm support [1]. > > > > > > Using tracing_prog_func_proto helpers for lsm programs. > > > > How about using raw_tp_prog_func_proto? > > why? > I think skb/xdp_output is useful for lsm progs too. > So I've applied the patch. right, it's also where d_path will be as well > > > PS: Please tag the patch with subject prefix "PATCH bpf" for > > "PATCH bpf-next". I think this one belongs to bpf-next, which means > > we should wait after the merge window. I must have missed info about that, thanks for info > > +1. > Jiri, > pls tag the subject properly. will do, sry thanks, jirka