From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 113B3C433DF for ; Fri, 5 Jun 2020 16:49:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFB62206F0 for ; Fri, 5 Jun 2020 16:49:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726648AbgFEQtm (ORCPT ); Fri, 5 Jun 2020 12:49:42 -0400 Received: from muru.com ([72.249.23.125]:57048 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725961AbgFEQtm (ORCPT ); Fri, 5 Jun 2020 12:49:42 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E034980F5; Fri, 5 Jun 2020 16:50:31 +0000 (UTC) Date: Fri, 5 Jun 2020 09:49:38 -0700 From: Tony Lindgren To: Navid Emamdoost Cc: Kalle Valo , "David S. Miller" , Johannes Berg , Thomas Gleixner , Greg Kroah-Hartman , Hari Nagalla , "Jason A. Donenfeld" , Emmanuel Grumbach , Maital Hahn , Fuqian Huang , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, emamd001@umn.edu, wu000273@umn.edu, kjlu@umn.edu, smccaman@umn.edu Subject: Re: [PATCH] wlcore: mesh: handle failure case of pm_runtime_get_sync Message-ID: <20200605164938.GH37466@atomide.com> References: <20200605032733.49846-1-navid.emamdoost@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200605032733.49846-1-navid.emamdoost@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org * Navid Emamdoost [200605 03:28]: > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count. Call pm_runtime_put if > pm_runtime_get_sync fails. Looks like we have a similar patch already in Linux next, care to check? Regards, Tony