From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
thomas.petazzoni@bootlin.com, lorenzo.bianconi@redhat.com,
brouer@redhat.com
Subject: Re: [PATCH net] net: mvneta: do not redirect frames during reconfiguration
Date: Tue, 9 Jun 2020 09:41:10 +0200 [thread overview]
Message-ID: <20200609074110.GA2067@localhost.localdomain> (raw)
In-Reply-To: <20200608231015.GH1022955@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
> On Tue, Jun 09, 2020 at 12:02:39AM +0200, Lorenzo Bianconi wrote:
> > Disable frames injection in mvneta_xdp_xmit routine during hw
> > re-configuration in order to avoid hardware hangs
>
> Hi Lorenzo
>
> Why does mvneta_tx() also not need the same protection?
>
> Andrew
Hi Andrew,
So far I have not been able to trigger the issue in the legacy tx path.
I hit the problem adding the capability to attach an eBPF program to CPUMAP
entries [1]. In particular I am redirecting traffic to mvneta and concurrently
attaching/removing a XDP program to/from it.
I am not sure this can occur running mvneta_tx().
Moreover it seems a common pattern for .ndo_xdp_xmit() in other drivers
(e.g ixgbe, bnxt, mlx5)
Regards,
Lorenzo
[1] https://patchwork.ozlabs.org/project/netdev/cover/cover.1590960613.git.lorenzo@kernel.org/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-06-09 7:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 22:02 [PATCH net] net: mvneta: do not redirect frames during reconfiguration Lorenzo Bianconi
2020-06-08 23:10 ` Andrew Lunn
2020-06-09 7:41 ` Lorenzo Bianconi [this message]
2020-06-09 13:06 ` Andrew Lunn
2020-06-09 14:27 ` Lorenzo Bianconi
2020-06-09 21:29 ` David Miller
2020-06-12 21:28 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609074110.GA2067@localhost.localdomain \
--to=lorenzo@kernel.org \
--cc=andrew@lunn.ch \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).