From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41AC1C433E1 for ; Tue, 9 Jun 2020 07:41:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A6142074B for ; Tue, 9 Jun 2020 07:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591688477; bh=QcmI30qSxZifxh5xML+gGikq+0x1Nw1MdPX5TCA5sic=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BngFaBjpaQ5h7nuTV7txA/Kna9e1ZfBLFIy5FsUxeZucgEewPeyBgmDRa23Cq0XB4 4sovogT5e4vmYCD4ekqTRFtC1N1Jw33EnWetf0tgKOGAqHHOscOmvu27l95ZHDl6tj 82lK287vHql+5OICeV/PDzxw8wld3Dnb26qIgwD0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726980AbgFIHlQ (ORCPT ); Tue, 9 Jun 2020 03:41:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:45358 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726404AbgFIHlP (ORCPT ); Tue, 9 Jun 2020 03:41:15 -0400 Received: from localhost (unknown [151.48.128.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6CC4D2081A; Tue, 9 Jun 2020 07:41:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591688475; bh=QcmI30qSxZifxh5xML+gGikq+0x1Nw1MdPX5TCA5sic=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X4lOu/Dc7ZHqJ8c8BVBqLTCDDsb5SQOyGr3944CP49HppKrHRoi05nnZ5gBBWpDaH myOAeX6N5ZUT5sIF0jIdzLMZi/mQkG7gFxg0OH+kvn5d2VaM6O8QhN69UguMKZGeM/ INJjpdPqLTuc4jQQVU6Hzslf91Kio/PDANzqnWko= Date: Tue, 9 Jun 2020 09:41:10 +0200 From: Lorenzo Bianconi To: Andrew Lunn Cc: netdev@vger.kernel.org, davem@davemloft.net, thomas.petazzoni@bootlin.com, lorenzo.bianconi@redhat.com, brouer@redhat.com Subject: Re: [PATCH net] net: mvneta: do not redirect frames during reconfiguration Message-ID: <20200609074110.GA2067@localhost.localdomain> References: <20200608231015.GH1022955@lunn.ch> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ibTvN161/egqYuK8" Content-Disposition: inline In-Reply-To: <20200608231015.GH1022955@lunn.ch> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On Tue, Jun 09, 2020 at 12:02:39AM +0200, Lorenzo Bianconi wrote: > > Disable frames injection in mvneta_xdp_xmit routine during hw > > re-configuration in order to avoid hardware hangs >=20 > Hi Lorenzo >=20 > Why does mvneta_tx() also not need the same protection? >=20 > Andrew Hi Andrew, So far I have not been able to trigger the issue in the legacy tx path. I hit the problem adding the capability to attach an eBPF program to CPUMAP entries [1]. In particular I am redirecting traffic to mvneta and concurren= tly attaching/removing a XDP program to/from it. I am not sure this can occur running mvneta_tx(). Moreover it seems a common pattern for .ndo_xdp_xmit() in other drivers (e.g ixgbe, bnxt, mlx5) Regards, Lorenzo [1] https://patchwork.ozlabs.org/project/netdev/cover/cover.1590960613.git.= lorenzo@kernel.org/ --ibTvN161/egqYuK8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXt89EwAKCRA6cBh0uS2t rOx+AQC+0fLmDvdpIIyE3hEO0zLOTTOncdvibkxHrE70rJtF1AEA8tETubun6QbR IB1es8y5S51m4fslombynBupK5Sr3g8= =4/NO -----END PGP SIGNATURE----- --ibTvN161/egqYuK8--