From: Kees Cook <keescook@chromium.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Christian Brauner <christian.brauner@ubuntu.com>,
"David S. Miller" <davem@davemloft.net>,
Christoph Hellwig <hch@lst.de>,
Christian Brauner <christian@brauner.io>,
Sargun Dhillon <sargun@sargun.me>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Use __scm_install_fd() more widely
Date: Wed, 10 Jun 2020 12:45:33 -0700 [thread overview]
Message-ID: <202006101245.DED83052@keescook> (raw)
In-Reply-To: <20200610113800.5d7846ce@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Wed, Jun 10, 2020 at 11:38:00AM -0700, Jakub Kicinski wrote:
> On Wed, 10 Jun 2020 10:03:03 -0700 Kees Cook wrote:
> > If 0-day doesn't kick anything back on this tree, I'll resend the
> > series...
>
> Well, 0-day may find more, but I can already tell you that patch 1 has
> a checkpatch error:
>
> ERROR: "(foo*)" should be "(foo *)"
> #149: FILE: net/core/scm.c:323:
> + (__force struct cmsghdr __user*)msg->msg_control;
>
> total: 1 errors, 0 warnings, 0 checks, 131 lines checked
>
> And patch 2 makes W=1 builds unhappy:
>
> net/core/scm.c:292: warning: Function parameter or member 'file' not described in '__scm_install_fd'
> net/core/scm.c:292: warning: Function parameter or member 'ufd' not described in '__scm_install_fd'
> net/core/scm.c:292: warning: Function parameter or member 'o_flags' not described in '__scm_install_fd'
Yeah, there are a few more problems too. I'll get it nailed down
hopefully this week and send a v2.
Thanks for looking at it!
--
Kees Cook
prev parent reply other threads:[~2020-06-10 19:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 4:52 [PATCH 0/2] Use __scm_install_fd() more widely Kees Cook
2020-06-10 4:52 ` [PATCH 1/2] net/scm: Regularize compat handling of scm_detach_fds() Kees Cook
2020-06-10 4:52 ` [PATCH 2/2] pidfd: Replace open-coded partial __scm_install_fd() Kees Cook
2020-06-10 16:45 ` Sargun Dhillon
2020-06-10 9:47 ` [PATCH 0/2] Use __scm_install_fd() more widely Christian Brauner
2020-06-10 14:52 ` Kees Cook
2020-06-10 17:03 ` Kees Cook
2020-06-10 18:38 ` Jakub Kicinski
2020-06-10 19:45 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006101245.DED83052@keescook \
--to=keescook@chromium.org \
--cc=christian.brauner@ubuntu.com \
--cc=christian@brauner.io \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sargun@sargun.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).