From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Calvin Johnson <calvin.johnson@oss.nxp.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jeremy Linton <jeremy.linton@arm.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH RFC v2 6/9] net: phy: add support for probing MMDs >= 8 for devices-in-package
Date: Wed, 10 Jun 2020 17:34:17 +0100 [thread overview]
Message-ID: <20200610163417.GR1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200610161633.GA22223@lsv03152.swis.in-blr01.nxp.com>
On Wed, Jun 10, 2020 at 09:46:33PM +0530, Calvin Johnson wrote:
> Hi Russell,
>
> On Wed, May 27, 2020 at 11:34:11AM +0100, Russell King wrote:
> > Add support for probing MMDs above 7 for a valid devices-in-package
> > specifier, but only probe the vendor MMDs for this if they also report
> > that there the device is present in status register 2. This avoids
> > issues where the MMD is implemented, but does not provide IEEE 802.3
> > compliant registers (such as the MV88X3310 PHY.)
>
> While this patch looks good to me, commit message doesn't seem to align
> with the code changes as it is dealing with MMD at addresses 30 & 31.
> Can you please clarify?
IEEE 802.3 does not define the "device-is-present" two bits in register
8 for all MMDs - it is only present for MMDs 1, 2, 3, 4, 5, 30 and 31.
None of the other MMDs, even those that have been recently defined (at
least in IEEE 802.3-2018) have these bits.
Hence, we can't use them except on the MMDs where they are defined to
be present.
I considered also checking them in MMDs 1, 2, 3, 4, 5, but decided that
the risk of regression was too high for this patch; that's something
which could be added in a separate patch though, to avoid having to
revert the entire thing if a regression is found at a later date.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 503kbps up
next prev parent reply other threads:[~2020-06-10 16:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 10:33 [PATCH RFC v2 0/9] Clause 45 PHY probing cleanups Russell King - ARM Linux admin
2020-05-27 10:33 ` [PATCH RFC v2 1/9] net: phy: clean up cortina workaround Russell King
2020-05-27 10:33 ` [PATCH RFC v2 2/9] net: phy: clean up PHY ID reading Russell King
2020-05-27 16:31 ` Florian Fainelli
2020-05-27 10:33 ` [PATCH RFC v2 3/9] net: phy: clean up get_phy_c45_ids() failure handling Russell King
2020-05-27 16:32 ` Florian Fainelli
2020-05-27 10:34 ` [PATCH RFC v2 4/9] net: phy: clean up get_phy_c22_id() invalid ID handling Russell King
2020-05-27 16:33 ` Florian Fainelli
2020-05-27 10:34 ` [PATCH RFC v2 5/9] net: phy: reword get_phy_device() kerneldoc Russell King
2020-05-27 16:33 ` Florian Fainelli
2020-05-27 10:34 ` [PATCH RFC v2 6/9] net: phy: add support for probing MMDs >= 8 for devices-in-package Russell King
2020-05-27 16:34 ` Florian Fainelli
2020-06-10 16:16 ` Calvin Johnson
2020-06-10 16:34 ` Russell King - ARM Linux admin [this message]
2020-06-11 6:01 ` Calvin Johnson
2020-05-27 10:34 ` [PATCH RFC v2 7/9] net: phy: set devices_in_package only after validation Russell King
2020-05-27 16:35 ` Florian Fainelli
2020-05-27 10:34 ` [PATCH RFC v2 8/9] net: phy: split devices_in_package Russell King
2020-05-27 16:36 ` Florian Fainelli
2020-05-27 10:34 ` [PATCH RFC v2 9/9] net: phy: read MMD ID from all present MMDs Russell King
2020-05-27 16:40 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610163417.GR1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=calvin.johnson@oss.nxp.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jeremy.linton@arm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).