From: Alex Elder <elder@linaro.org>
To: davem@davemloft.net, kuba@kernel.org
Cc: evgreen@chromium.org, subashab@codeaurora.org,
cpratapa@codeaurora.org, bjorn.andersson@linaro.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net 5/5] net: ipa: warn if gsi_trans structure is too big
Date: Wed, 10 Jun 2020 14:53:32 -0500 [thread overview]
Message-ID: <20200610195332.2612233-6-elder@linaro.org> (raw)
In-Reply-To: <20200610195332.2612233-1-elder@linaro.org>
When the DEBUG_SPINLOCK and DEBUG_LOCK_ALLOC config options are
enabled, sizeof(raw_spinlock_t) grows considerably (from 4 bytes
to 56 bytes currently). As a consequence the size of the gsi_trans
structure exceeds 128 bytes, and this triggers a BUILD_BUG_ON()
error.
These are useful configuration options to enable, so rather than
causing a build failure, just issue a warning message at run time
if the structure is larger than we'd prefer.
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/net/ipa/ipa_main.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
index 76d5108b8403..94d9aa0e999b 100644
--- a/drivers/net/ipa/ipa_main.c
+++ b/drivers/net/ipa/ipa_main.c
@@ -669,9 +669,6 @@ static void ipa_validate_build(void)
*/
BUILD_BUG_ON(GSI_TLV_MAX > U8_MAX);
- /* Exceeding 128 bytes makes the transaction pool *much* larger */
- BUILD_BUG_ON(sizeof(struct gsi_trans) > 128);
-
/* This is used as a divisor */
BUILD_BUG_ON(!IPA_AGGR_GRANULARITY);
#endif /* IPA_VALIDATE */
@@ -715,6 +712,10 @@ static int ipa_probe(struct platform_device *pdev)
int ret;
ipa_validate_build();
+ /* Exceeding 128 bytes makes the transaction pool *much* larger */
+ if (sizeof(struct gsi_trans) > 128)
+ dev_warn(dev, "WARNING: sizeof(struct gsi_trans) = %zu\n",
+ sizeof(struct gsi_trans));
/* If we need Trust Zone, make sure it's available */
modem_init = of_property_read_bool(dev->of_node, "modem-init");
--
2.25.1
next prev parent reply other threads:[~2020-06-10 19:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 19:53 [PATCH net 0/5] net: ipa: endpoint configuration fixes Alex Elder
2020-06-10 19:53 ` [PATCH net 1/5] net: ipa: program metadata mask differently Alex Elder
[not found] ` <202006110832.hKzHUsMH%lkp@intel.com>
2020-06-11 19:18 ` Alex Elder
2020-06-10 19:53 ` [PATCH net 2/5] net: ipa: fix modem LAN RX endpoint id Alex Elder
2020-06-10 19:53 ` [PATCH net 3/5] net: ipa: program upper nibbles of sequencer type Alex Elder
2020-06-10 19:53 ` [PATCH net 4/5] net: ipa: header pad field only valid for AP->modem endpoint Alex Elder
2020-06-10 19:53 ` Alex Elder [this message]
2020-06-10 23:36 ` [PATCH net 5/5] net: ipa: warn if gsi_trans structure is too big David Miller
2020-06-11 12:58 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610195332.2612233-6-elder@linaro.org \
--to=elder@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).