From: Pablo Neira Ayuso <pablo@netfilter.org>
To: wenxu@ucloud.cn
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net 2/2] flow_offload: fix miss cleanup flow_block_cb of indr_setup_ft_cb type
Date: Thu, 11 Jun 2020 11:47:02 +0200 [thread overview]
Message-ID: <20200611094702.GA19063@salvia> (raw)
In-Reply-To: <1591846217-3514-2-git-send-email-wenxu@ucloud.cn>
On Thu, Jun 11, 2020 at 11:30:17AM +0800, wenxu@ucloud.cn wrote:
> From: wenxu <wenxu@ucloud.cn>
>
> Currently indr setup supoort both indr_setup_ft_cb and indr_setup_tc_cb.
> But the __flow_block_indr_cleanup only check the indr_setup_tc_cb in
> mlx5e driver.
> It is better to just check the indr_release_cb, all the setup_cb type
> share the same release_cb.
I think patch 1/2 and 2/2 should be collapsed into one single patch.
(Non-native English) suggestion for your patch description:
"If the representor is removed, then identify the indirect flow_blocks
that need to be removed by the release callback."
Thank you.
next prev parent reply other threads:[~2020-06-11 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 3:30 [PATCH net 1/2] flow_offload: fix incorrect cb_priv check for flow_block_cb wenxu
2020-06-11 3:30 ` [PATCH net 2/2] flow_offload: fix miss cleanup flow_block_cb of indr_setup_ft_cb type wenxu
2020-06-11 9:47 ` Pablo Neira Ayuso [this message]
2020-06-11 10:39 ` Vlad Buslov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611094702.GA19063@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).