From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86DC5C433DF for ; Mon, 15 Jun 2020 20:11:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65D8F207D4 for ; Mon, 15 Jun 2020 20:11:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730898AbgFOULy (ORCPT ); Mon, 15 Jun 2020 16:11:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728870AbgFOULy (ORCPT ); Mon, 15 Jun 2020 16:11:54 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B3E4C061A0E for ; Mon, 15 Jun 2020 13:11:54 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C3C82120ED49A; Mon, 15 Jun 2020 13:11:53 -0700 (PDT) Date: Mon, 15 Jun 2020 13:11:53 -0700 (PDT) Message-Id: <20200615.131153.658696666759727641.davem@davemloft.net> To: ckeepax@opensource.cirrus.com Cc: nicolas.ferre@microchip.com, kuba@kernel.org, clabbe@baylibre.com, netdev@vger.kernel.org Subject: Re: [PATCH] net: macb: Only disable NAPI on the actual error path From: David Miller In-Reply-To: <20200615131854.12187-1-ckeepax@opensource.cirrus.com> References: <20200615131854.12187-1-ckeepax@opensource.cirrus.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 15 Jun 2020 13:11:54 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Charles Keepax Date: Mon, 15 Jun 2020 14:18:54 +0100 > A recent change added a disable to NAPI into macb_open, this was > intended to only happen on the error path but accidentally applies > to all paths. This causes NAPI to be disabled on the success path, which > leads to the network to no longer functioning. > > Fixes: 014406babc1f ("net: cadence: macb: disable NAPI on error") > Signed-off-by: Charles Keepax Applied, thank you.